chrome/browser/signin/easy_unlock_screenlock_state_handler.h - Issue 649313004: Standardize usage of virtual/override/final in chrome/browser/signin/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/easy_unlock_screenlock_state_handler.h

Issue 649313004: Standardize usage of virtual/override/final in chrome/browser/signin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/signin/chrome_signin_client_factory.h ('k') | chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/easy_unlock_screenlock_state_handler.h

diff --git a/chrome/browser/signin/easy_unlock_screenlock_state_handler.h b/chrome/browser/signin/easy_unlock_screenlock_state_handler.h

index a86af96eb4d2c6726c22c729e0e6bb4dffa08467..e80eaf4ee1bbc4dade65b1fb5e7f117bf1807b2c 100644

--- a/chrome/browser/signin/easy_unlock_screenlock_state_handler.h

+++ b/chrome/browser/signin/easy_unlock_screenlock_state_handler.h

@@ -61,7 +61,7 @@ class EasyUnlockScreenlockStateHandler : public ScreenlockBridge::Observer {

EasyUnlockScreenlockStateHandler(const std::string& user_email,

HardlockState initial_hardlock_state,

ScreenlockBridge* screenlock_bridge);

- virtual ~EasyUnlockScreenlockStateHandler();

+ ~EasyUnlockScreenlockStateHandler() override;

// Returns true if handler is not in INACTIVE state.

bool IsActive() const;

@@ -81,9 +81,9 @@ class EasyUnlockScreenlockStateHandler : public ScreenlockBridge::Observer {

private:

// ScreenlockBridge::Observer:

- virtual void OnScreenDidLock() override;

- virtual void OnScreenDidUnlock() override;

- virtual void OnFocusedUserChanged(const std::string& user_id) override;

+ void OnScreenDidLock() override;

+ void OnScreenDidUnlock() override;

+ void OnFocusedUserChanged(const std::string& user_id) override;

// Forces refresh of the Easy Unlock screenlock UI.

void RefreshScreenlockState();