chrome/browser/signin/easy_unlock_service.h - Issue 649313004: Standardize usage of virtual/override/final in chrome/browser/signin/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/easy_unlock_service.h

Issue 649313004: Standardize usage of virtual/override/final in chrome/browser/signin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc ('k') | chrome/browser/signin/easy_unlock_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/easy_unlock_service.h

diff --git a/chrome/browser/signin/easy_unlock_service.h b/chrome/browser/signin/easy_unlock_service.h

index 2e3c7b4669098a21884a222aab5aec5314d3d78c..8a77b7c6a06963d92d126c53865b57209d28ecd7 100644

--- a/chrome/browser/signin/easy_unlock_service.h

+++ b/chrome/browser/signin/easy_unlock_service.h

@@ -153,7 +153,7 @@ class EasyUnlockService : public KeyedService {

protected:

explicit EasyUnlockService(Profile* profile);

- virtual ~EasyUnlockService();

+ ~EasyUnlockService() override;

// Does a service type specific initialization.

virtual void InitializeInternal() = 0;

@@ -167,7 +167,7 @@ class EasyUnlockService : public KeyedService {

virtual bool IsAllowedInternal() = 0;

// KeyedService override:

- virtual void Shutdown() override;

+ void Shutdown() override;

// Exposes the profile to which the service is attached to subclasses.

Profile* profile() const { return profile_; }