Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7495)

Unified Diff: chrome/browser/signin/signin_manager_unittest.cc

Issue 649313004: Standardize usage of virtual/override/final in chrome/browser/signin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/signin_manager_factory.h ('k') | chrome/browser/signin/signin_names_io_thread.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_manager_unittest.cc
diff --git a/chrome/browser/signin/signin_manager_unittest.cc b/chrome/browser/signin/signin_manager_unittest.cc
index 6df559d9ffb10e4bda62be365d37999795ce65cd..1c439998a981d972ec1ca097cf1df467c13d461f 100644
--- a/chrome/browser/signin/signin_manager_unittest.cc
+++ b/chrome/browser/signin/signin_manager_unittest.cc
@@ -61,7 +61,7 @@ class TestSigninManagerObserver : public SigninManagerBase::Observer {
num_signouts_(0) {
}
- virtual ~TestSigninManagerObserver() {}
+ ~TestSigninManagerObserver() override {}
int num_failed_signins_;
int num_successful_signins_;
@@ -69,20 +69,18 @@ class TestSigninManagerObserver : public SigninManagerBase::Observer {
private:
// SigninManagerBase::Observer:
- virtual void GoogleSigninFailed(
- const GoogleServiceAuthError& error) override {
+ void GoogleSigninFailed(const GoogleServiceAuthError& error) override {
num_failed_signins_++;
}
- virtual void GoogleSigninSucceeded(
- const std::string& account_id,
- const std::string& username,
- const std::string& password) override {
+ void GoogleSigninSucceeded(const std::string& account_id,
+ const std::string& username,
+ const std::string& password) override {
num_successful_signins_++;
}
- virtual void GoogleSignedOut(const std::string& account_id,
- const std::string& username) override {
+ void GoogleSignedOut(const std::string& account_id,
+ const std::string& username) override {
num_signouts_++;
}
};
« no previous file with comments | « chrome/browser/signin/signin_manager_factory.h ('k') | chrome/browser/signin/signin_names_io_thread.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698