Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: chrome/browser/signin/signin_names_io_thread.h

Issue 649313004: Standardize usage of virtual/override/final in chrome/browser/signin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/signin_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_names_io_thread.h
diff --git a/chrome/browser/signin/signin_names_io_thread.h b/chrome/browser/signin/signin_names_io_thread.h
index dbef056dabea843482fc5589241b7ed28b4abc65..134930830deb7c3fbdafbe2038c41987056e52a4 100644
--- a/chrome/browser/signin/signin_names_io_thread.h
+++ b/chrome/browser/signin/signin_names_io_thread.h
@@ -30,7 +30,7 @@ class SigninNamesOnIOThread : public SigninManagerBase::Observer,
// Objects should only be created on UI thread.
SigninNamesOnIOThread();
- virtual ~SigninNamesOnIOThread();
+ ~SigninNamesOnIOThread() override;
// Gets the set of email addresses of connected profiles. This method should
// only be called on the IO thread.
@@ -42,15 +42,15 @@ class SigninNamesOnIOThread : public SigninManagerBase::Observer,
private:
// SigninManagerBase::Observer:
- virtual void GoogleSigninSucceeded(const std::string& account_id,
- const std::string& username,
- const std::string& password) override;
- virtual void GoogleSignedOut(const std::string& account_id,
- const std::string& username) override;
+ void GoogleSigninSucceeded(const std::string& account_id,
+ const std::string& username,
+ const std::string& password) override;
+ void GoogleSignedOut(const std::string& account_id,
+ const std::string& username) override;
// SigninManagerFactory::Observer:
- virtual void SigninManagerCreated(SigninManagerBase* manager) override;
- virtual void SigninManagerShutdown(SigninManagerBase* manager) override;
+ void SigninManagerCreated(SigninManagerBase* manager) override;
+ void SigninManagerShutdown(SigninManagerBase* manager) override;
// Checks whether the current thread is the IO thread.
void CheckOnIOThread() const;
« no previous file with comments | « chrome/browser/signin/signin_manager_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698