Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 649283003: Standardize usage of virtual/override/final in google_apis/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in google_apis/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=rogerta@chromium.org Committed: https://crrev.com/f93bb58024cffd2b08e691f43138d789641708cb Cr-Commit-Position: refs/heads/master@{#300495}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+459 lines, -480 lines) Patch
M google_apis/drive/auth_service.h View 1 chunk +11 lines, -11 lines 0 comments Download
M google_apis/drive/auth_service.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M google_apis/drive/base_requests.h View 10 chunks +43 lines, -43 lines 0 comments Download
M google_apis/drive/base_requests_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M google_apis/drive/drive_api_requests.h View 39 chunks +79 lines, -81 lines 0 comments Download
M google_apis/drive/dummy_auth_service.h View 1 chunk +8 lines, -8 lines 0 comments Download
M google_apis/drive/gdata_wapi_parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/drive/gdata_wapi_requests.h View 1 chunk +4 lines, -4 lines 0 comments Download
M google_apis/drive/request_sender_unittest.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M google_apis/gaia/account_tracker.h View 3 chunks +14 lines, -14 lines 0 comments Download
M google_apis/gaia/account_tracker_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M google_apis/gaia/fake_identity_provider.h View 1 chunk +5 lines, -5 lines 0 comments Download
M google_apis/gaia/fake_oauth2_token_service.h View 3 chunks +15 lines, -16 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_oauth_client_unittest.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M google_apis/gaia/identity_provider.h View 2 chunks +4 lines, -4 lines 0 comments Download
M google_apis/gaia/merge_session_helper.h View 5 chunks +9 lines, -11 lines 0 comments Download
M google_apis/gaia/mock_url_fetcher_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl.h View 1 chunk +6 lines, -6 lines 0 comments Download
M google_apis/gaia/oauth2_api_call_flow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow.h View 1 chunk +5 lines, -7 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request.h View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request_unittest.cc View 4 chunks +22 lines, -22 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_test_util.h View 1 chunk +6 lines, -6 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_unittest.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M google_apis/gaia/ubertoken_fetcher.h View 1 chunk +8 lines, -9 lines 0 comments Download
M google_apis/gaia/ubertoken_fetcher_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M google_apis/gcm/base/fake_encryptor.h View 1 chunk +5 lines, -5 lines 0 comments Download
M google_apis/gcm/base/socket_stream.h View 2 chunks +9 lines, -9 lines 0 comments Download
M google_apis/gcm/engine/checkin_request.h View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/connection_factory_impl.h View 1 chunk +10 lines, -10 lines 0 comments Download
M google_apis/gcm/engine/connection_factory_impl_unittest.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M google_apis/gcm/engine/connection_handler_impl.h View 1 chunk +6 lines, -7 lines 0 comments Download
M google_apis/gcm/engine/fake_connection_factory.h View 1 chunk +9 lines, -9 lines 0 comments Download
M google_apis/gcm/engine/fake_connection_handler.h View 1 chunk +6 lines, -7 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.h View 1 chunk +38 lines, -40 lines 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/registration_request.h View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/unregistration_request.h View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gcm/monitoring/fake_gcm_stats_recorder.h View 1 chunk +38 lines, -41 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 4 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dcheng
6 years, 2 months ago (2014-10-21 10:57:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649283003/1
6 years, 2 months ago (2014-10-21 11:01:10 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/27562)
6 years, 2 months ago (2014-10-21 12:46:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/649283003/1
6 years, 2 months ago (2014-10-21 15:44:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 16:12:11 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 16:13:01 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f93bb58024cffd2b08e691f43138d789641708cb
Cr-Commit-Position: refs/heads/master@{#300495}

Powered by Google App Engine
This is Rietveld 408576698