google_apis/gaia/gaia_oauth_client.cc - Issue 649283003: Standardize usage of virtual/override/final in google_apis/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gaia/gaia_oauth_client.cc

Issue 649283003: Standardize usage of virtual/override/final in google_apis/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: google_apis/gaia/gaia_oauth_client.cc

diff --git a/google_apis/gaia/gaia_oauth_client.cc b/google_apis/gaia/gaia_oauth_client.cc

index 8f2565e3835bfb696e588227c38a99e4953f6f0c..06605070af1fc9cc5743d7e3a1b56449da0f3d81 100644

--- a/google_apis/gaia/gaia_oauth_client.cc

+++ b/google_apis/gaia/gaia_oauth_client.cc

@@ -65,7 +65,7 @@ class GaiaOAuthClient::Core

Delegate* delegate);

// net::URLFetcherDelegate implementation.

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

private:

friend class base::RefCountedThreadSafe<Core>;

@@ -80,7 +80,7 @@ class GaiaOAuthClient::Core

USER_INFO,

};

- virtual ~Core() {}

+ ~Core() override {}

void GetUserInfoImpl(RequestType type,

const std::string& oauth_access_token,

« no previous file with comments | « google_apis/gaia/gaia_auth_fetcher.h ('k') | google_apis/gaia/gaia_oauth_client_unittest.cc » ('j') | no next file with comments »