Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Unified Diff: google_apis/drive/request_sender_unittest.cc

Issue 649283003: Standardize usage of virtual/override/final in google_apis/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « google_apis/drive/gdata_wapi_requests.h ('k') | google_apis/gaia/account_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: google_apis/drive/request_sender_unittest.cc
diff --git a/google_apis/drive/request_sender_unittest.cc b/google_apis/drive/request_sender_unittest.cc
index 7771164ad869ee109b7f2f7d1a121f436f45ddc0..545257858d8f609340724422c132e928c10db2af 100644
--- a/google_apis/drive/request_sender_unittest.cc
+++ b/google_apis/drive/request_sender_unittest.cc
@@ -31,8 +31,7 @@ class TestAuthService : public DummyAuthService {
public:
TestAuthService() : auth_try_count_(0) {}
- virtual void StartAuthentication(
- const AuthStatusCallback& callback) override {
+ void StartAuthentication(const AuthStatusCallback& callback) override {
// RequestSender should clear the rejected access token before starting
// to request another one.
EXPECT_FALSE(HasAccessToken());
@@ -95,9 +94,9 @@ class TestRequest : public AuthenticatedRequestInterface {
return passed_reauth_callback_;
}
- virtual void Start(const std::string& access_token,
- const std::string& custom_user_agent,
- const ReAuthenticateCallback& callback) override {
+ void Start(const std::string& access_token,
+ const std::string& custom_user_agent,
+ const ReAuthenticateCallback& callback) override {
*start_called_ = true;
passed_access_token_ = access_token;
passed_reauth_callback_ = callback;
@@ -106,18 +105,18 @@ class TestRequest : public AuthenticatedRequestInterface {
// Each test case should respond properly by using the above methods.
}
- virtual void Cancel() override {
+ void Cancel() override {
EXPECT_TRUE(*start_called_);
*finish_reason_ = CANCEL;
sender_->RequestFinished(this);
}
- virtual void OnAuthFailed(GDataErrorCode code) override {
+ void OnAuthFailed(GDataErrorCode code) override {
*finish_reason_ = AUTH_FAILURE;
sender_->RequestFinished(this);
}
- virtual base::WeakPtr<AuthenticatedRequestInterface> GetWeakPtr() override {
+ base::WeakPtr<AuthenticatedRequestInterface> GetWeakPtr() override {
return weak_ptr_factory_.GetWeakPtr();
}
« no previous file with comments | « google_apis/drive/gdata_wapi_requests.h ('k') | google_apis/gaia/account_tracker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698