Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: google_apis/gaia/oauth2_token_service_request.cc

Issue 649283003: Standardize usage of virtual/override/final in google_apis/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gaia/oauth2_token_service_request.cc
diff --git a/google_apis/gaia/oauth2_token_service_request.cc b/google_apis/gaia/oauth2_token_service_request.cc
index 8301fd5e055d56165f5e1ef43a4f46f1d9192264..ee7d6500a1b33137f409eb67d017a4937d217ebc 100644
--- a/google_apis/gaia/oauth2_token_service_request.cc
+++ b/google_apis/gaia/oauth2_token_service_request.cc
@@ -163,21 +163,21 @@ class RequestCore : public OAuth2TokenServiceRequest::Core,
const OAuth2TokenService::ScopeSet& scopes);
// OAuth2TokenService::Consumer. Must be called on the token service thread.
- virtual void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
- const std::string& access_token,
- const base::Time& expiration_time) override;
- virtual void OnGetTokenFailure(const OAuth2TokenService::Request* request,
- const GoogleServiceAuthError& error) override;
+ void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
+ const std::string& access_token,
+ const base::Time& expiration_time) override;
+ void OnGetTokenFailure(const OAuth2TokenService::Request* request,
+ const GoogleServiceAuthError& error) override;
private:
friend class base::RefCountedThreadSafe<RequestCore>;
// Must be destroyed on the owner thread.
- virtual ~RequestCore();
+ ~RequestCore() override;
// Core implementation.
- virtual void StartOnTokenServiceThread() override;
- virtual void StopOnTokenServiceThread() override;
+ void StartOnTokenServiceThread() override;
+ void StopOnTokenServiceThread() override;
void InformOwnerOnGetTokenSuccess(std::string access_token,
base::Time expiration_time);
@@ -279,11 +279,11 @@ class InvalidateCore : public OAuth2TokenServiceRequest::Core {
friend class base::RefCountedThreadSafe<InvalidateCore>;
// Must be destroyed on the owner thread.
- virtual ~InvalidateCore();
+ ~InvalidateCore() override;
// Core implementation.
- virtual void StartOnTokenServiceThread() override;
- virtual void StopOnTokenServiceThread() override;
+ void StartOnTokenServiceThread() override;
+ void StopOnTokenServiceThread() override;
std::string access_token_;
std::string account_id_;
« no previous file with comments | « google_apis/gaia/oauth2_token_service_request.h ('k') | google_apis/gaia/oauth2_token_service_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698