Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: google_apis/gcm/engine/connection_factory_impl.h

Issue 649283003: Standardize usage of virtual/override/final in google_apis/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/connection_factory_impl.h
diff --git a/google_apis/gcm/engine/connection_factory_impl.h b/google_apis/gcm/engine/connection_factory_impl.h
index 21eeedbe0094600f2a2c7607c70a2e49bbeef544..b28e8f622a4f85e3bbb62d75acaa8ce24502d757 100644
--- a/google_apis/gcm/engine/connection_factory_impl.h
+++ b/google_apis/gcm/engine/connection_factory_impl.h
@@ -42,23 +42,23 @@ class GCM_EXPORT ConnectionFactoryImpl :
const scoped_refptr<net::HttpNetworkSession>& http_network_session,
net::NetLog* net_log,
GCMStatsRecorder* recorder);
- virtual ~ConnectionFactoryImpl();
+ ~ConnectionFactoryImpl() override;
// ConnectionFactory implementation.
- virtual void Initialize(
+ void Initialize(
const BuildLoginRequestCallback& request_builder,
const ConnectionHandler::ProtoReceivedCallback& read_callback,
const ConnectionHandler::ProtoSentCallback& write_callback) override;
- virtual ConnectionHandler* GetConnectionHandler() const override;
- virtual void Connect() override;
- virtual bool IsEndpointReachable() const override;
- virtual std::string GetConnectionStateString() const override;
- virtual base::TimeTicks NextRetryAttempt() const override;
- virtual void SignalConnectionReset(ConnectionResetReason reason) override;
- virtual void SetConnectionListener(ConnectionListener* listener) override;
+ ConnectionHandler* GetConnectionHandler() const override;
+ void Connect() override;
+ bool IsEndpointReachable() const override;
+ std::string GetConnectionStateString() const override;
+ base::TimeTicks NextRetryAttempt() const override;
+ void SignalConnectionReset(ConnectionResetReason reason) override;
+ void SetConnectionListener(ConnectionListener* listener) override;
// NetworkChangeObserver implementation.
- virtual void OnNetworkChanged(
+ void OnNetworkChanged(
net::NetworkChangeNotifier::ConnectionType type) override;
// Returns the server to which the factory is currently connected, or if
« no previous file with comments | « google_apis/gcm/engine/checkin_request.h ('k') | google_apis/gcm/engine/connection_factory_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698