Standardize usage of virtual/override/final in gin/

Standardize usage of virtual/override/final in gin/

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=abarth@chromium.org

Committed: https://crrev.com/074c039593e8beb054fcc7a2701e753883eaa596
Cr-Commit-Position: refs/heads/master@{#300925}

[Avi (use Gerrit), 2014-10-21 20:48:20]

On 2014/10/21 20:46:59, dcheng wrote:

In your description:

- virtual void Foo() override;        ->  void Override();
- virtual void Foo() override final;  ->  void Override();

Don't you mean:

- virtual void Foo() override;        ->  void Override() override;
- virtual void Foo() override final;  ->  void Override() final;

?

[dcheng, 2014-10-21 20:49:30]

On 2014/10/21 at 20:48:20, avi wrote:
> On 2014/10/21 20:46:59, dcheng wrote:
> 
> In your description:
> 
> - virtual void Foo() override;        ->  void Override();
> - virtual void Foo() override final;  ->  void Override();
> 
> Don't you mean:
> 
> - virtual void Foo() override;        ->  void Override() override;
> - virtual void Foo() override final;  ->  void Override() final;
> 
> ?

Gah. You're right. Fixing this now...

[dcheng, 2014-10-22 21:50:02]

dcheng@chromium.org changed reviewers:
+ aa@chromium.org

[dcheng, 2014-10-22 21:50:02]

aa@, mind taking a look at this?

[Aaron Boodman, 2014-10-23 17:56:21]

cool, lgtm

[dcheng, 2014-10-23 17:57:41]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-10-23 17:58:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/645853012/1

[commit-bot: I haz the power, 2014-10-23 19:08:34]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-23 19:09:51]

Patchset 1 (id:??) landed as
https://crrev.com/074c039593e8beb054fcc7a2701e753883eaa596
Cr-Commit-Position: refs/heads/master@{#300925}