gin/run_microtasks_observer.h - Issue 645853012: Standardize usage of virtual/override/final in gin/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/run_microtasks_observer.h

Issue 645853012: Standardize usage of virtual/override/final in gin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/run_microtasks_observer.h

diff --git a/gin/run_microtasks_observer.h b/gin/run_microtasks_observer.h

index d31d80467a4e2031b622f7e76ce4162d2bf659fd..7f1431fb2ec253f579e1f487aa9ffc2759d9c6d6 100644

--- a/gin/run_microtasks_observer.h

+++ b/gin/run_microtasks_observer.h

@@ -18,8 +18,8 @@ class RunMicrotasksObserver : public base::MessageLoop::TaskObserver {

public:

RunMicrotasksObserver(v8::Isolate* isolate);

- virtual void WillProcessTask(const base::PendingTask& pending_task) override;

- virtual void DidProcessTask(const base::PendingTask& pending_task) override;

+ void WillProcessTask(const base::PendingTask& pending_task) override;

+ void DidProcessTask(const base::PendingTask& pending_task) override;

private:

v8::Isolate* isolate_;

« no previous file with comments | « gin/public/v8_platform.h ('k') | gin/shell/gin_main.cc » ('j') | no next file with comments »