gin/shell/gin_main.cc - Issue 645853012: Standardize usage of virtual/override/final in gin/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/shell/gin_main.cc

Issue 645853012: Standardize usage of virtual/override/final in gin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/shell/gin_main.cc

diff --git a/gin/shell/gin_main.cc b/gin/shell/gin_main.cc

index 77b167a43b67af7e517c9a70d3cab0d6b7ba48bf..b17ec0af006ee0eaf258a0478da8a22550c90e6d 100644

--- a/gin/shell/gin_main.cc

+++ b/gin/shell/gin_main.cc

@@ -44,8 +44,7 @@ class GinShellRunnerDelegate : public ModuleRunnerDelegate {

AddBuiltinModule(Console::kModuleName, Console::GetModule);

}

- virtual void UnhandledException(ShellRunner* runner,

- TryCatch& try_catch) override {

+ void UnhandledException(ShellRunner* runner, TryCatch& try_catch) override {

ModuleRunnerDelegate::UnhandledException(runner, try_catch);

LOG(ERROR) << try_catch.GetStackTrace();

}

« no previous file with comments | « gin/run_microtasks_observer.h ('k') | gin/shell_runner.h » ('j') | no next file with comments »