Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: gin/modules/timer.h

Issue 645853012: Standardize usage of virtual/override/final in gin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gin/modules/module_runner_delegate.h ('k') | gin/modules/timer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_MODULES_TIMER_H_ 5 #ifndef GIN_MODULES_TIMER_H_
6 #define GIN_MODULES_TIMER_H_ 6 #define GIN_MODULES_TIMER_H_
7 7
8 #include "base/memory/weak_ptr.h" 8 #include "base/memory/weak_ptr.h"
9 #include "base/timer/timer.h" 9 #include "base/timer/timer.h"
10 #include "gin/gin_export.h" 10 #include "gin/gin_export.h"
(...skipping 11 matching lines...) Expand all
22 public: 22 public:
23 enum TimerType { 23 enum TimerType {
24 TYPE_ONE_SHOT, 24 TYPE_ONE_SHOT,
25 TYPE_REPEATING 25 TYPE_REPEATING
26 }; 26 };
27 27
28 static WrapperInfo kWrapperInfo; 28 static WrapperInfo kWrapperInfo;
29 static Handle<Timer> Create(TimerType type, v8::Isolate* isolate, 29 static Handle<Timer> Create(TimerType type, v8::Isolate* isolate,
30 int delay_ms, v8::Handle<v8::Function> function); 30 int delay_ms, v8::Handle<v8::Function> function);
31 31
32 virtual ObjectTemplateBuilder GetObjectTemplateBuilder( 32 ObjectTemplateBuilder GetObjectTemplateBuilder(v8::Isolate* isolate) override;
33 v8::Isolate* isolate) override;
34 33
35 private: 34 private:
36 Timer(v8::Isolate* isolate, bool repeating, int delay_ms, 35 Timer(v8::Isolate* isolate, bool repeating, int delay_ms,
37 v8::Handle<v8::Function> function); 36 v8::Handle<v8::Function> function);
38 virtual ~Timer(); 37 ~Timer() override;
39 void OnTimerFired(); 38 void OnTimerFired();
40 39
41 base::Timer timer_; 40 base::Timer timer_;
42 base::WeakPtr<gin::Runner> runner_; 41 base::WeakPtr<gin::Runner> runner_;
43 base::WeakPtrFactory<Timer> weak_factory_; 42 base::WeakPtrFactory<Timer> weak_factory_;
44 43
45 DISALLOW_COPY_AND_ASSIGN(Timer); 44 DISALLOW_COPY_AND_ASSIGN(Timer);
46 }; 45 };
47 46
48 47
49 class GIN_EXPORT TimerModule : public Wrappable<TimerModule> { 48 class GIN_EXPORT TimerModule : public Wrappable<TimerModule> {
50 public: 49 public:
51 static const char kName[]; 50 static const char kName[];
52 static WrapperInfo kWrapperInfo; 51 static WrapperInfo kWrapperInfo;
53 static Handle<TimerModule> Create(v8::Isolate* isolate); 52 static Handle<TimerModule> Create(v8::Isolate* isolate);
54 static v8::Local<v8::Value> GetModule(v8::Isolate* isolate); 53 static v8::Local<v8::Value> GetModule(v8::Isolate* isolate);
55 54
56 private: 55 private:
57 TimerModule(); 56 TimerModule();
58 virtual ~TimerModule(); 57 ~TimerModule() override;
59 58
60 virtual ObjectTemplateBuilder GetObjectTemplateBuilder( 59 ObjectTemplateBuilder GetObjectTemplateBuilder(v8::Isolate* isolate) override;
61 v8::Isolate* isolate) override;
62 }; 60 };
63 61
64 } // namespace gin 62 } // namespace gin
65 63
66 #endif // GIN_MODULES_TIMER_H_ 64 #endif // GIN_MODULES_TIMER_H_
OLDNEW
« no previous file with comments | « gin/modules/module_runner_delegate.h ('k') | gin/modules/timer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698