gin/modules/module_registry_unittest.cc - Issue 645853012: Standardize usage of virtual/override/final in gin/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/modules/module_registry_unittest.cc

Issue 645853012: Standardize usage of virtual/override/final in gin/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gin/modules/module_registry_unittest.cc

diff --git a/gin/modules/module_registry_unittest.cc b/gin/modules/module_registry_unittest.cc

index 57bc02d5ec02426129dea7ffc30322fdc71434de..3d784dc7f9f8db20b83c4a3ed8b43689f948c4e3 100644

--- a/gin/modules/module_registry_unittest.cc

+++ b/gin/modules/module_registry_unittest.cc

@@ -35,7 +35,7 @@ class ModuleRegistryObserverImpl : public ModuleRegistryObserver {

public:

ModuleRegistryObserverImpl() : did_add_count_(0) {}

- virtual void OnDidAddPendingModule(

+ void OnDidAddPendingModule(

const std::string& id,

const std::vector<std::string>& dependencies) override {

did_add_count_++;

« no previous file with comments | « gin/interceptor_unittest.cc ('k') | gin/modules/module_runner_delegate.h » ('j') | no next file with comments »