Adding Presubmit error when OVERRIDE and FINAL is not used as C++11 standard

Adding Presubmit error when OVERRIDE and FINAL is not used as C++11 standard

Alerting the error for use to use c++11 constructs |override| and |final| instead of OVERRIDE and FINAL respctively

BUG=417463
TBR=ben@chromium.org

Committed: https://crrev.com/f6935316b438a3848141644c9d10098de3da0a2d
Cr-Commit-Position: refs/heads/master@{#299435}

[MRV, 2014-10-08 04:55:15]

mohan.reddy@samsung.com changed reviewers:
+ ben@chromium.org

[MRV, 2014-10-08 04:55:16]

PTAL

[MRV, 2014-10-09 13:57:40]

On 2014/10/08 04:55:16, MRV wrote:
> PTAL

Dear Mr. Ben PTAL

[Avi (use Gerrit), 2014-10-09 15:30:21]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2014-10-09 15:30:22]

https://codereview.chromium.org/638663003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/638663003/diff/1/PRESUBMIT.py#newcode372
PRESUBMIT.py:372: 'FINAL as final as per C++11 \n' +
This is awkward and mis-spelled English. I would phrase it as

Use C++11's |override| and |final| rather than OVERRIDE and FINAL.

And why isn't this an error rather than a warning? Warnings are for uses that
might be correct, but the use of OVERRIDE and FINAL is never correct any more.

[MRV, 2014-10-10 03:04:52]

On 2014/10/09 15:30:22, Avi wrote:
> https://codereview.chromium.org/638663003/diff/1/PRESUBMIT.py
> File PRESUBMIT.py (right):
> 
> https://codereview.chromium.org/638663003/diff/1/PRESUBMIT.py#newcode372
> PRESUBMIT.py:372: 'FINAL as final as per C++11 \n' +
> This is awkward and mis-spelled English. I would phrase it as
> 
> Use C++11's |override| and |final| rather than OVERRIDE and FINAL.
> 
> And why isn't this an error rather than a warning? Warnings are for uses that
> might be correct, but the use of OVERRIDE and FINAL is never correct any more.

Dear Mr. Avi, thanks for your feedback.
I have incorporated the changes mentioned.

PTAL

[MRV, 2014-10-10 03:06:04]

Thanks Mr. Avi for the feedback.
I have incorporated said changes.

PTAL

https://codereview.chromium.org/638663003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.chromium.org/638663003/diff/1/PRESUBMIT.py#newcode372
PRESUBMIT.py:372: 'FINAL as final as per C++11 \n' +
On 2014/10/09 15:30:22, Avi wrote:
> This is awkward and mis-spelled English. I would phrase it as
> 
> Use C++11's |override| and |final| rather than OVERRIDE and FINAL.
> 
> And why isn't this an error rather than a warning? Warnings are for uses that
> might be correct, but the use of OVERRIDE and FINAL is never correct any more.

Done.

[Avi (use Gerrit), 2014-10-10 15:07:49]

LGTM but I don't have the authority to approve it.

Ben?

[MRV, 2014-10-10 15:08:59]

On 2014/10/10 15:07:49, Avi wrote:
> LGTM but I don't have the authority to approve it.
> 
> Ben?

Thanks Mr. Avi for review.
Mr. Ben, could you please review my patch.

Thank you :).

[MRV, 2014-10-13 10:06:08]

On 2014/10/10 15:08:59, MRV wrote:
> On 2014/10/10 15:07:49, Avi wrote:
> > LGTM but I don't have the authority to approve it.
> > 
> > Ben?
> 
> Thanks Mr. Avi for review.
> Mr. Ben, could you please review my patch.
> 
> Thank you :).

Dear Mr. Ben,

Could you please review this patch, delay incurring lots of patches, which we
can prevent.
This is recurring lots of patches like below:
https://codereview.chromium.org/653593003/
https://codereview.chromium.org/648133002/
https://codereview.chromium.org/653583002/

PTAL.

[Avi (use Gerrit), 2014-10-13 20:06:22]

avi@chromium.org changed reviewers:
+ maruel@chromium.org
- ben@chromium.org

[Avi (use Gerrit), 2014-10-13 20:06:22]

Let's pick a different OWNER. Marc-Antoine?

[MRV, 2014-10-14 01:56:43]

On 2014/10/13 20:06:22, Avi wrote:
> Let's pick a different OWNER. Marc-Antoine?

Thank you mr.avi.
@mr.marc could you please review my patch.

[MRV, 2014-10-14 04:59:15]

On 2014/10/14 01:56:43, MRV wrote:
> On 2014/10/13 20:06:22, Avi wrote:
> > Let's pick a different OWNER. Marc-Antoine?
> 
> Thank you mr.avi.
> @mr.marc could you please review my patch.

Dear All PRESUBMIT.py owners, Please review my patch.
Delay in my patch is heading to lots of addtion of similay patches in the git
repo like below:
https://codereview.chromium.org/658453002/
https://codereview.chromium.org/657453002/
https://codereview.chromium.org/655553003/
https://codereview.chromium.org/636233004/
https://codereview.chromium.org/653593003/
e.t.c.,

So please PTAL

[Avi (use Gerrit), 2014-10-14 05:01:26]

On 2014/10/14 04:59:15, MRV wrote:
> On 2014/10/14 01:56:43, MRV wrote:
> > On 2014/10/13 20:06:22, Avi wrote:
> > > Let's pick a different OWNER. Marc-Antoine?
> > 
> > Thank you mr.avi.
> > @mr.marc could you please review my patch.
> 
> Dear All PRESUBMIT.py owners, Please review my patch.
> Delay in my patch is heading to lots of addtion of similay patches in the git
> repo like below:
> https://codereview.chromium.org/658453002/
> https://codereview.chromium.org/657453002/
> https://codereview.chromium.org/655553003/
> https://codereview.chromium.org/636233004/
> https://codereview.chromium.org/653593003/
> e.t.c.,
> 
> So please PTAL

I'm making the TBR call.

[Avi (use Gerrit), 2014-10-14 05:01:45]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-10-14 05:02:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/638663003/40001

[commit-bot: I haz the power, 2014-10-14 05:57:56]

Committed patchset #3 (id:40001)

[MRV, 2014-10-14 06:12:29]

On 2014/10/14 05:57:56, I haz the power (commit-bot) wrote:
> Committed patchset #3 (id:40001)

Thanks a lot Mr. Avi.

[commit-bot: I haz the power, 2014-10-14 06:17:34]

Patchset 3 (id:??) landed as
https://crrev.com/f6935316b438a3848141644c9d10098de3da0a2d
Cr-Commit-Position: refs/heads/master@{#299435}

[Mike West, 2014-10-14 07:17:29]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/659443002/ by mkwst@chromium.org.

The reason for reverting is: The if statement is incorrect. `if 'override' or
'final' in line` === `if 'override'`, because string constants are always true.
This means that no one can upload patches, which is a bit annoying.

Please fix in a subsequent patch..

[MRV, 2014-10-14 09:50:24]

On 2014/10/14 07:17:29, Mike West wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/659443002/ by mailto:mkwst@chromium.org.
> 
> The reason for reverting is: The if statement is incorrect. `if 'override' or
> 'final' in line` === `if 'override'`, because string constants are always
true.
> This means that no one can upload patches, which is a bit annoying.
> 
> Please fix in a subsequent patch..

Thanks Mr. Mike for reverting, I have resubmitted the patch
"https://codereview.chromium.org/653883002/" which covers all most all the
cases.
Mr. Avi my sincere apologies to you. 

Iam learning more from this sort of mistakes and from next time I'll committed
enough to not to repeat this or any sort of issues again.

Thanks again for sparing your time for me.

[M-A Ruel, 2014-10-14 14:33:10]

Please do not TBR PRESUBMIT.py patches. I was travelling and Monday was a
national holiday in Canada.

[Avi (use Gerrit), 2014-10-14 14:44:47]

On 2014/10/14 14:33:10, M-A Ruel wrote:
> Please do not TBR PRESUBMIT.py patches. I was travelling and Monday was a
> national holiday in Canada.

My fault. Apologies.