Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 636233004: remove some new OVERRIDE instances in ui/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
rjkroege, tapted, sky, danakj
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, ozone-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove some new OVERRIDE instances in ui/ BUG=417463 Committed: https://crrev.com/c189d183795073ed9e2b8641542d2392464b2617 Cr-Commit-Position: refs/heads/master@{#299444}

Patch Set 1 #

Patch Set 2 : fix a few more new OVERRIDEs in ui/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M ui/app_list/cocoa/apps_grid_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/ozone/platform/dri/dri_window.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_mac_interactive_uitest.mm View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
tapted
ui/app_list lgtm
6 years, 2 months ago (2014-10-10 00:51:31 UTC) #2
Mostyn Bramley-Moore
Added a few more fixups for newly added OVERRIDEs. @rjkroege: PTAL at ui/ozone/platform/dri/dri_window.h @sky: PTAL ...
6 years, 2 months ago (2014-10-13 08:58:13 UTC) #4
sky
LGTM
6 years, 2 months ago (2014-10-13 17:11:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636233004/60001
6 years, 2 months ago (2014-10-14 06:12:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17434)
6 years, 2 months ago (2014-10-14 06:19:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636233004/60001
6 years, 2 months ago (2014-10-14 07:37:05 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:60001)
6 years, 2 months ago (2014-10-14 07:40:33 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 08:15:20 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c189d183795073ed9e2b8641542d2392464b2617
Cr-Commit-Position: refs/heads/master@{#299444}

Powered by Google App Engine
This is Rietveld 408576698