Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 659443002: Revert of Adding Presubmit error when OVERRIDE and FINAL is not used as C++11 standard (Closed)

Created:
6 years, 2 months ago by Mike West
Modified:
6 years, 2 months ago
CC:
chromium-reviews, sky, darin (slow to review), Ben, M-A Ruel, jochen (gone - plz use gerrit), Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Adding Presubmit error when OVERRIDE and FINAL is not used as C++11 standard (patchset #3 id:40001 of https://codereview.chromium.org/638663003/) Reason for revert: The if statement is incorrect. `if 'override' or 'final' in line` === `if 'override'`, because string constants are always true. This means that no one can upload patches, which is a bit annoying. Please fix in a subsequent patch. Original issue's description: > Adding Presubmit error when OVERRIDE and FINAL is not used as C++11 standard > > Alerting the error for use to use c++11 constructs |override| and |final| instead of OVERRIDE and FINAL respctively > > BUG=417463 > TBR=ben@chromium.org > > Committed: https://crrev.com/f6935316b438a3848141644c9d10098de3da0a2d > Cr-Commit-Position: refs/heads/master@{#299435} TBR=avi@chromium.org,maruel@chromium.org,mohan.reddy@samsung.com NOTREECHECKS=true NOTRY=true BUG=417463 Committed: https://crrev.com/a9639ff031f757c31bf35dfe3229e9f0dfd9aec9 Cr-Commit-Position: refs/heads/master@{#299442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mike West
Created Revert of Adding Presubmit error when OVERRIDE and FINAL is not used as C++11 ...
6 years, 2 months ago (2014-10-14 07:17:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659443002/1
6 years, 2 months ago (2014-10-14 07:17:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-14 07:18:10 UTC) #3
MRV
On 2014/10/14 07:18:10, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) I ...
6 years, 2 months ago (2014-10-14 07:36:37 UTC) #4
Mike West
On 2014/10/14 07:36:37, MRV wrote: > On 2014/10/14 07:18:10, I haz the power (commit-bot) wrote: ...
6 years, 2 months ago (2014-10-14 07:38:43 UTC) #5
Mike West
On 2014/10/14 07:38:43, Mike West wrote: > On 2014/10/14 07:36:37, MRV wrote: > > On ...
6 years, 2 months ago (2014-10-14 07:39:35 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 08:15:09 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9639ff031f757c31bf35dfe3229e9f0dfd9aec9
Cr-Commit-Position: refs/heads/master@{#299442}

Powered by Google App Engine
This is Rietveld 408576698