DescriptionRevert of Adding Presubmit error when OVERRIDE and FINAL is not used as C++11 standard (patchset #3 id:40001 of https://codereview.chromium.org/638663003/)
Reason for revert:
The if statement is incorrect. `if 'override' or 'final' in line` === `if 'override'`, because string constants are always true. This means that no one can upload patches, which is a bit annoying.
Please fix in a subsequent patch.
Original issue's description:
> Adding Presubmit error when OVERRIDE and FINAL is not used as C++11 standard
>
> Alerting the error for use to use c++11 constructs |override| and |final| instead of OVERRIDE and FINAL respctively
>
> BUG=417463
> TBR=ben@chromium.org
>
> Committed: https://crrev.com/f6935316b438a3848141644c9d10098de3da0a2d
> Cr-Commit-Position: refs/heads/master@{#299435}
TBR=avi@chromium.org,maruel@chromium.org,mohan.reddy@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=417463
Committed: https://crrev.com/a9639ff031f757c31bf35dfe3229e9f0dfd9aec9
Cr-Commit-Position: refs/heads/master@{#299442}
Patch Set 1 #
Created: 6 years, 2 months ago
(Patch set is too large to download)
Messages
Total messages: 7 (0 generated)
|