Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 657453002: Replace OVERRIDE with their C++11 counterparts in chrome (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE with their C++11 counterparts in chrome This is fix for newly added OVERRIDE construts in chrome folder. This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/ui/app_list/app_list_prefs_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/model_pref_updater.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/model_pref_updater_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 25 (11 generated)
MRV
Dear Mr. Lei Zhang, these were newly added OVERRIDE constructs in chrome PTAL.
6 years, 2 months ago (2014-10-14 04:00:39 UTC) #2
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-14 22:55:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657453002/1
6 years, 2 months ago (2014-10-14 22:56:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17641)
6 years, 2 months ago (2014-10-14 23:32:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657453002/1
6 years, 2 months ago (2014-10-14 23:50:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17665)
6 years, 2 months ago (2014-10-15 00:26:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657453002/1
6 years, 2 months ago (2014-10-15 01:59:19 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17698)
6 years, 2 months ago (2014-10-15 02:33:33 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657453002/1
6 years, 2 months ago (2014-10-15 07:02:36 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17734)
6 years, 2 months ago (2014-10-15 07:25:53 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657453002/1
6 years, 2 months ago (2014-10-15 08:58:01 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17745)
6 years, 2 months ago (2014-10-15 09:23:43 UTC) #23
Lei Zhang
It looks like r299342 already made the exact same fixes as this CL.
6 years, 2 months ago (2014-10-15 18:37:59 UTC) #24
MRV
6 years, 2 months ago (2014-10-16 03:26:45 UTC) #25
On 2014/10/15 18:37:59, Lei Zhang wrote:
> It looks like r299342 already made the exact same fixes as this CL.

Thanks Mr. Lei Zhang.
Closing the issue now.

Powered by Google App Engine
This is Rietveld 408576698