Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 658453002: Replace OVERRIDE with their C++11 counterparts in extensions (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
benwells
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace OVERRIDE with their C++11 counterparts in extensions This is fix for newly added OVERRIDE construts in extensions folder. This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/92b1a0fda90441ccd8e2d4bdf91a5657e24f10d4 Cr-Commit-Position: refs/heads/master@{#299448}

Patch Set 1 #

Patch Set 2 : Corrected Patch-set1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-14 04:56:17 UTC) #2
benwells
lgtm
6 years, 2 months ago (2014-10-14 06:21:01 UTC) #3
MRV
On 2014/10/14 06:21:01, benwells wrote: > lgtm Thanks Mr. benwells.
6 years, 2 months ago (2014-10-14 07:14:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658453002/20001
6 years, 2 months ago (2014-10-14 07:14:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/17442)
6 years, 2 months ago (2014-10-14 07:20:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/658453002/20001
6 years, 2 months ago (2014-10-14 08:53:16 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 2 months ago (2014-10-14 08:56:14 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 08:56:54 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/92b1a0fda90441ccd8e2d4bdf91a5657e24f10d4
Cr-Commit-Position: refs/heads/master@{#299448}

Powered by Google App Engine
This is Rietveld 408576698