Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 638403003: Remove uses of GrAutoScratchTexture. (Closed)

Created:
6 years, 2 months ago by bsalomon
Modified:
6 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove uses of GrAutoScratchTexture. Rename GrContext::lockAndRefScratchTexture to refScratchTexture. GrSurface::writePixels returns bool instead of void. BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/e30597375c19dfb5197fd065a3d1768401eb00fa

Patch Set 1 #

Patch Set 2 : comment update #

Patch Set 3 : comment change #

Total comments: 4

Patch Set 4 : rebase and address comment #

Total comments: 2

Patch Set 5 : fix indent #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -134 lines) Patch
M include/gpu/GrContext.h View 1 2 3 2 chunks +12 lines, -11 lines 0 comments Download
M include/gpu/GrSurface.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 2 3 4 5 2 chunks +5 lines, -5 lines 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 2 3 4 5 1 chunk +4 lines, -3 lines 0 comments Download
M src/effects/SkGpuBlurUtils.cpp View 2 chunks +14 lines, -11 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 2 3 4 5 2 chunks +12 lines, -14 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 4 5 4 chunks +5 lines, -9 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrSWMaskHelper.h View 3 chunks +4 lines, -5 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 3 chunks +6 lines, -8 lines 0 comments Download
M src/gpu/GrSoftwarePathRenderer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrTexture.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 3 4 5 6 chunks +22 lines, -35 lines 0 comments Download
M src/gpu/SkGr.cpp View 1 2 3 4 3 chunks +9 lines, -9 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ReadPixelsTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/WritePixelsTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
bsalomon
This leaves the clip mask manager as the only user of AST in Skia. There ...
6 years, 2 months ago (2014-10-09 15:11:22 UTC) #2
robertphillips
https://codereview.chromium.org/638403003/diff/40001/src/effects/SkDisplacementMapEffect.cpp File src/effects/SkDisplacementMapEffect.cpp (right): https://codereview.chromium.org/638403003/diff/40001/src/effects/SkDisplacementMapEffect.cpp#newcode418 src/effects/SkDisplacementMapEffect.cpp:418: context->refScratchTexture(desc, GrContext::kApprox_ScratchTexMatch)); if (!dst) { return false; } ? ...
6 years, 2 months ago (2014-10-09 17:19:50 UTC) #3
bsalomon
https://codereview.chromium.org/638403003/diff/40001/src/effects/SkDisplacementMapEffect.cpp File src/effects/SkDisplacementMapEffect.cpp (right): https://codereview.chromium.org/638403003/diff/40001/src/effects/SkDisplacementMapEffect.cpp#newcode418 src/effects/SkDisplacementMapEffect.cpp:418: context->refScratchTexture(desc, GrContext::kApprox_ScratchTexMatch)); On 2014/10/09 17:19:50, robertphillips wrote: > if ...
6 years, 2 months ago (2014-10-13 15:42:02 UTC) #4
robertphillips
lgtm + a nit https://codereview.chromium.org/638403003/diff/90001/src/gpu/SkGr.cpp File src/gpu/SkGr.cpp (right): https://codereview.chromium.org/638403003/diff/90001/src/gpu/SkGr.cpp#newcode273 src/gpu/SkGr.cpp:273: SkAutoTUnref<GrFragmentProcessor> yuvToRgbProcessor(GrYUVtoRGBEffect::Create( indent here ?
6 years, 2 months ago (2014-10-13 17:52:22 UTC) #5
bsalomon
https://codereview.chromium.org/638403003/diff/90001/src/gpu/SkGr.cpp File src/gpu/SkGr.cpp (right): https://codereview.chromium.org/638403003/diff/90001/src/gpu/SkGr.cpp#newcode273 src/gpu/SkGr.cpp:273: SkAutoTUnref<GrFragmentProcessor> yuvToRgbProcessor(GrYUVtoRGBEffect::Create( On 2014/10/13 17:52:22, robertphillips wrote: > indent ...
6 years, 2 months ago (2014-10-13 18:01:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638403003/440001
6 years, 2 months ago (2014-10-14 18:40:58 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 18:47:26 UTC) #9
Message was sent while issue was closed. 
Committed patchset #6 (id:440001) as e30597375c19dfb5197fd065a3d1768401eb00fa

Powered by Google App Engine
This is Rietveld 408576698