Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 637933002: Replace FINAL and OVERRIDE with their C++11 counterparts in chrome/test (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in chrome/test This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/bf928b3167a24bea2c7a69101ba753781898d7b9 Cr-Commit-Position: refs/heads/master@{#298976}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+624 lines, -624 lines) Patch
M chrome/test/base/browser_perf_tests_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/browser_tests_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_process_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_render_view_host_test_harness.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/test/base/chrome_test_launcher.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/chrome_test_suite.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_unit_test_suite.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_unit_test_suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/extension_load_waiter_one_shot.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/find_in_page_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/history_index_restore_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/interactive_ui_tests_main.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/javascript_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/menu_model_test.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 2 chunks +101 lines, -101 lines 0 comments Download
M chrome/test/base/test_browser_window.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_chrome_web_ui_controller_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/test_chrome_web_ui_controller_factory_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 chunk +48 lines, -48 lines 0 comments Download
M chrome/test/base/testing_browser_process_platform_part.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.h View 2 chunks +48 lines, -48 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/base/testing_profile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/tracing.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/base/v8_unit_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/view_event_test_base.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/view_event_test_platform_part_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/view_event_test_platform_part_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/view_event_test_platform_part_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/web_ui_browser_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/web_ui_browser_test.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/base/web_ui_browser_test_browsertest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/chrome/adb_impl.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome_android_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome_desktop_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome_impl.h View 1 chunk +9 lines, -9 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome_remote_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/console_logger.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/console_logger_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/chrome/debugger_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/device_manager_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/test/chromedriver/chrome/devtools_client_impl.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc View 22 chunks +54 lines, -54 lines 0 comments Download
M chrome/test/chromedriver/chrome/dom_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/dom_tracker_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/frame_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/geolocation_override_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/geolocation_override_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/heap_snapshot_taker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/heap_snapshot_taker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/javascript_dialog_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/chrome/mobile_emulation_override_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/navigation_tracker.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/stub_chrome.h View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/test/chromedriver/chrome/stub_devtools_client.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/test/chromedriver/chrome/stub_web_view.h View 1 chunk +26 lines, -26 lines 0 comments Download
M chrome/test/chromedriver/chrome/web_view_impl.h View 1 chunk +26 lines, -26 lines 0 comments Download
M chrome/test/chromedriver/chrome/web_view_impl_unittest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/test/chromedriver/command_listener_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/command_listener_proxy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/commands_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/logging.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/net_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/net/net_util_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/net/sync_websocket_impl.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/chromedriver/net/sync_websocket_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/net/test_http_server.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/net/url_request_context_getter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/net/websocket_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/chromedriver/performance_logger.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/performance_logger_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/chromedriver/server/chromedriver_server.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/session_commands_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/session_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/async_gen.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/webui/chrome_send_browsertest.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/data/webui/history_ui_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/gpu/webgl_infobar_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/logging/win/log_file_printer.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/logging/win/test_log_collector.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest_uma.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest_util.h View 5 chunks +16 lines, -16 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/nacl/pnacl_header_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/browser_perf_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/perf/mach_ports_performancetest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/ppapi/ppapi_test.h View 6 chunks +30 lines, -30 lines 0 comments Download
M chrome/test/remoting/remote_desktop_browsertest.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/remoting/waiter.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-08 12:15:09 UTC) #2
MRV
On 2014/10/08 12:15:09, MRV wrote: > PTAL Dear mr. Lei zhang or mr.sky PTAL
6 years, 2 months ago (2014-10-09 14:05:02 UTC) #4
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-09 18:07:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637933002/1
6 years, 2 months ago (2014-10-09 18:08:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/22512)
6 years, 2 months ago (2014-10-09 19:41:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637933002/1
6 years, 2 months ago (2014-10-09 19:44:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-09 20:53:15 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-09 20:53:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf928b3167a24bea2c7a69101ba753781898d7b9
Cr-Commit-Position: refs/heads/master@{#298976}

Powered by Google App Engine
This is Rietveld 408576698