Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Side by Side Diff: chrome/test/chromedriver/chrome/geolocation_override_manager_unittest.cc

Issue 637933002: Replace FINAL and OVERRIDE with their C++11 counterparts in chrome/test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/test/chromedriver/chrome/geolocation_override_manager.h" 10 #include "chrome/test/chromedriver/chrome/geolocation_override_manager.h"
(...skipping 27 matching lines...) Expand all
38 38
39 class RecorderDevToolsClient : public StubDevToolsClient { 39 class RecorderDevToolsClient : public StubDevToolsClient {
40 public: 40 public:
41 RecorderDevToolsClient() {} 41 RecorderDevToolsClient() {}
42 virtual ~RecorderDevToolsClient() {} 42 virtual ~RecorderDevToolsClient() {}
43 43
44 // Overridden from StubDevToolsClient: 44 // Overridden from StubDevToolsClient:
45 virtual Status SendCommandAndGetResult( 45 virtual Status SendCommandAndGetResult(
46 const std::string& method, 46 const std::string& method,
47 const base::DictionaryValue& params, 47 const base::DictionaryValue& params,
48 scoped_ptr<base::DictionaryValue>* result) OVERRIDE { 48 scoped_ptr<base::DictionaryValue>* result) override {
49 commands_.push_back(Command(method, params)); 49 commands_.push_back(Command(method, params));
50 return Status(kOk); 50 return Status(kOk);
51 } 51 }
52 52
53 std::vector<Command> commands_; 53 std::vector<Command> commands_;
54 }; 54 };
55 55
56 void AssertGeolocationCommand(const Command& command, 56 void AssertGeolocationCommand(const Command& command,
57 const Geoposition& geoposition) { 57 const Geoposition& geoposition) {
58 ASSERT_EQ("Page.setGeolocationOverride", command.method); 58 ASSERT_EQ("Page.setGeolocationOverride", command.method);
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 ASSERT_NO_FATAL_FAILURE( 117 ASSERT_NO_FATAL_FAILURE(
118 AssertGeolocationCommand(client.commands_[1], geoposition)); 118 AssertGeolocationCommand(client.commands_[1], geoposition));
119 119
120 base::DictionaryValue sub_frame_params; 120 base::DictionaryValue sub_frame_params;
121 sub_frame_params.SetString("frame.parentId", "id"); 121 sub_frame_params.SetString("frame.parentId", "id");
122 ASSERT_EQ( 122 ASSERT_EQ(
123 kOk, 123 kOk,
124 manager.OnEvent(&client, "Page.frameNavigated", sub_frame_params).code()); 124 manager.OnEvent(&client, "Page.frameNavigated", sub_frame_params).code());
125 ASSERT_EQ(2u, client.commands_.size()); 125 ASSERT_EQ(2u, client.commands_.size());
126 } 126 }
OLDNEW
« no previous file with comments | « chrome/test/chromedriver/chrome/geolocation_override_manager.h ('k') | chrome/test/chromedriver/chrome/heap_snapshot_taker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698