chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc - Issue 637933002: Replace FINAL and OVERRIDE with their C++11 counterparts in chrome/test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc

Issue 637933002: Replace FINAL and OVERRIDE with their C++11 counterparts in chrome/test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/javascript_dialog_manager.h ('k') | chrome/test/chromedriver/chrome/mobile_emulation_override_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc

diff --git a/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc b/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc

index 487478423fa4005176edde1e344b0e118efd1a52..99666726560ad19a3d29d640aa6cad509fed6f69 100644

--- a/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc

+++ b/chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc

@@ -33,7 +33,7 @@ class RecorderDevToolsClient : public StubDevToolsClient {

virtual Status SendCommandAndGetResult(

const std::string& method,

const base::DictionaryValue& params,

- scoped_ptr<base::DictionaryValue>* result) OVERRIDE {

+ scoped_ptr<base::DictionaryValue>* result) override {

method_ = method;

params_.Clear();

params_.MergeDictionary(&params);

@@ -109,7 +109,7 @@ class FakeDevToolsClient : public StubDevToolsClient {

virtual Status SendCommandAndGetResult(

const std::string& method,

const base::DictionaryValue& params,

- scoped_ptr<base::DictionaryValue>* result) OVERRIDE {

+ scoped_ptr<base::DictionaryValue>* result) override {

while (closing_count_ > 0) {

base::DictionaryValue empty;

Status status =

@@ -120,7 +120,7 @@ class FakeDevToolsClient : public StubDevToolsClient {

}

return Status(kOk);

}

- virtual void AddListener(DevToolsEventListener* listener) OVERRIDE {

+ virtual void AddListener(DevToolsEventListener* listener) override {

listener_ = listener;

}