chrome/test/chromedriver/chrome/devtools_client_impl.h - Issue 637933002: Replace FINAL and OVERRIDE with their C++11 counterparts in chrome/test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/devtools_client_impl.h

Issue 637933002: Replace FINAL and OVERRIDE with their C++11 counterparts in chrome/test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/chromedriver/chrome/device_manager_unittest.cc ('k') | chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/devtools_client_impl.h

diff --git a/chrome/test/chromedriver/chrome/devtools_client_impl.h b/chrome/test/chromedriver/chrome/devtools_client_impl.h

index 34bb203efb589835e9dffe359324a96f462ffe65..3d4d9e55da2f23befe4670f6876cb7c73483ed16 100644

--- a/chrome/test/chromedriver/chrome/devtools_client_impl.h

+++ b/chrome/test/chromedriver/chrome/devtools_client_impl.h

@@ -81,20 +81,20 @@ class DevToolsClientImpl : public DevToolsClient {

void SetParserFuncForTesting(const ParserFunc& parser_func);

// Overridden from DevToolsClient:

- virtual const std::string& GetId() OVERRIDE;

- virtual bool WasCrashed() OVERRIDE;

- virtual Status ConnectIfNecessary() OVERRIDE;

+ virtual const std::string& GetId() override;

+ virtual bool WasCrashed() override;

+ virtual Status ConnectIfNecessary() override;

virtual Status SendCommand(const std::string& method,

- const base::DictionaryValue& params) OVERRIDE;

+ const base::DictionaryValue& params) override;

virtual Status SendCommandAndGetResult(

const std::string& method,

const base::DictionaryValue& params,

- scoped_ptr<base::DictionaryValue>* result) OVERRIDE;

- virtual void AddListener(DevToolsEventListener* listener) OVERRIDE;

+ scoped_ptr<base::DictionaryValue>* result) override;

+ virtual void AddListener(DevToolsEventListener* listener) override;

virtual Status HandleEventsUntil(

const ConditionalFunc& conditional_func,

- const base::TimeDelta& timeout) OVERRIDE;

- virtual Status HandleReceivedEvents() OVERRIDE;

+ const base::TimeDelta& timeout) override;

+ virtual Status HandleReceivedEvents() override;

private:

enum ResponseState {