Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc

Issue 637933002: Replace FINAL and OVERRIDE with their C++11 counterparts in chrome/test (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/test/chromedriver/chrome/browser_info.h" 10 #include "chrome/test/chromedriver/chrome/browser_info.h"
(...skipping 28 matching lines...) Expand all
39 39
40 class RecorderDevToolsClient : public StubDevToolsClient { 40 class RecorderDevToolsClient : public StubDevToolsClient {
41 public: 41 public:
42 RecorderDevToolsClient() {} 42 RecorderDevToolsClient() {}
43 virtual ~RecorderDevToolsClient() {} 43 virtual ~RecorderDevToolsClient() {}
44 44
45 // Overridden from StubDevToolsClient: 45 // Overridden from StubDevToolsClient:
46 virtual Status SendCommandAndGetResult( 46 virtual Status SendCommandAndGetResult(
47 const std::string& method, 47 const std::string& method,
48 const base::DictionaryValue& params, 48 const base::DictionaryValue& params,
49 scoped_ptr<base::DictionaryValue>* result) OVERRIDE { 49 scoped_ptr<base::DictionaryValue>* result) override {
50 commands_.push_back(Command(method, params)); 50 commands_.push_back(Command(method, params));
51 return Status(kOk); 51 return Status(kOk);
52 } 52 }
53 53
54 std::vector<Command> commands_; 54 std::vector<Command> commands_;
55 }; 55 };
56 56
57 void AssertDeviceMetricsCommand(const Command& command, 57 void AssertDeviceMetricsCommand(const Command& command,
58 const DeviceMetrics& device_metrics) { 58 const DeviceMetrics& device_metrics) {
59 ASSERT_EQ("Page.setDeviceMetricsOverride", command.method); 59 ASSERT_EQ("Page.setDeviceMetricsOverride", command.method);
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 ASSERT_NO_FATAL_FAILURE( 115 ASSERT_NO_FATAL_FAILURE(
116 AssertDeviceMetricsCommand(client.commands_[1], device_metrics)); 116 AssertDeviceMetricsCommand(client.commands_[1], device_metrics));
117 117
118 base::DictionaryValue sub_frame_params; 118 base::DictionaryValue sub_frame_params;
119 sub_frame_params.SetString("frame.parentId", "id"); 119 sub_frame_params.SetString("frame.parentId", "id");
120 ASSERT_EQ( 120 ASSERT_EQ(
121 kOk, 121 kOk,
122 manager.OnEvent(&client, "Page.frameNavigated", sub_frame_params).code()); 122 manager.OnEvent(&client, "Page.frameNavigated", sub_frame_params).code());
123 ASSERT_EQ(2u, client.commands_.size()); 123 ASSERT_EQ(2u, client.commands_.size());
124 } 124 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698