Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Issue 634543004: Start to vectorize SkTileGrid. (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Start to vectorize SkTileGrid. This adds Sk4x.h to help. BUG=skia:3041 Committed: https://skia.googlesource.com/skia/+/90c7992bfc6330f070f7704d63372a0ec8410170 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu12-ShuttleA-GTX660-x86-Debug-Trybot Committed: https://skia.googlesource.com/skia/+/958e9628d5f9a81aeafa78572cb4afc4b19a455a

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : rebase #

Patch Set 4 : minor tweaks #

Patch Set 5 : more tuning: inc/exc later, fix intersects(), add sorted() and Sk4All #

Patch Set 6 : tweak loop #

Patch Set 7 : rebase #

Patch Set 8 : tune loop #

Patch Set 9 : restore intersects check for now to simplify change #

Patch Set 10 : tweaks #

Total comments: 2

Patch Set 11 : rearrange a bit more #

Patch Set 12 : new approach #

Patch Set 13 : interface in Sk4x.h #

Patch Set 14 : compiles with gcc too #

Patch Set 15 : split gcc and clang #

Patch Set 16 : sketch Sk4x_nosimd.h #

Patch Set 17 : undef BINOP #

Patch Set 18 : names and comments #

Patch Set 19 : todos #

Patch Set 20 : nosimd -> portable #

Patch Set 21 : improve gcc codegen #

Patch Set 22 : sketch sse2 #

Patch Set 23 : compiles and links #

Patch Set 24 : seems to be correct now #

Patch Set 25 : code for sse2 imul, add sse4.1 variants #

Patch Set 26 : terser formatting #

Patch Set 27 : tweaks #

Patch Set 28 : simplify swizzle interface #

Total comments: 2

Patch Set 29 : note #

Patch Set 30 : rebase #

Patch Set 31 : rebase #

Patch Set 32 : nl #

Patch Set 33 : comments #

Patch Set 34 : fNumTiles #

Patch Set 35 : add 4f intersect and sort benches #

Patch Set 36 : intersect with scalars #

Patch Set 37 : update comment #

Patch Set 38 : cruft #

Patch Set 39 : zwxy #

Patch Set 40 : windows warning #

Patch Set 41 : separate lines #

Patch Set 42 : enforce alignment #

Patch Set 43 : Windows, what are you talking about? #

Patch Set 44 : faster this way #

Patch Set 45 : suppress warning #

Patch Set 46 : Drop _gcc.h for now. #

Patch Set 47 : resuppress #

Patch Set 48 : revert portable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+484 lines, -56 lines) Patch
M bench/GeometryBench.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 5 chunks +62 lines, -2 lines 0 comments Download
M gyp/common_conditions.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 46 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkTypes.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +3 lines, -0 lines 0 comments Download
A src/core/Sk4x.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 1 chunk +92 lines, -0 lines 0 comments Download
A src/core/Sk4x_clang.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 1 chunk +125 lines, -0 lines 0 comments Download
A src/core/Sk4x_portable.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 40 41 42 43 44 46 47 1 chunk +134 lines, -0 lines 0 comments Download
M src/core/SkTileGrid.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 2 chunks +9 lines, -8 lines 0 comments Download
M src/core/SkTileGrid.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 4 chunks +58 lines, -46 lines 0 comments Download

Messages

Total messages: 81 (27 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/200001
6 years, 2 months ago (2014-10-10 15:46:33 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-10 15:46:34 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/2041) Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1812)
6 years, 2 months ago (2014-10-10 15:49:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/310001
6 years, 2 months ago (2014-10-10 16:02:49 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-10 16:02:50 UTC) #8
reed1
https://codereview.chromium.org/634543004/diff/310001/src/core/Sk4x.h File src/core/Sk4x.h (right): https://codereview.chromium.org/634543004/diff/310001/src/core/Sk4x.h#newcode80 src/core/Sk4x.h:80: inline bool Sk4All(Sk4i v) { as we start to ...
6 years, 2 months ago (2014-10-10 16:06:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1065)
6 years, 2 months ago (2014-10-10 16:06:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/450001
6 years, 2 months ago (2014-10-10 17:22:44 UTC) #14
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-10 17:22:45 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/2049)
6 years, 2 months ago (2014-10-10 17:25:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/600001
6 years, 2 months ago (2014-10-10 19:25:38 UTC) #19
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-10 19:25:39 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/1822)
6 years, 2 months ago (2014-10-10 19:28:49 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/690001
6 years, 2 months ago (2014-10-10 19:59:44 UTC) #24
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-10 19:59:45 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/750001
6 years, 2 months ago (2014-10-10 20:24:55 UTC) #27
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-10 20:24:56 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2211)
6 years, 2 months ago (2014-10-10 20:42:35 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/870001
6 years, 2 months ago (2014-10-10 21:08:13 UTC) #32
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-10 21:08:15 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/950001
6 years, 2 months ago (2014-10-10 21:18:32 UTC) #35
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-10 21:18:33 UTC) #36
mtklein
https://codereview.chromium.org/634543004/diff/310001/src/core/Sk4x.h File src/core/Sk4x.h (right): https://codereview.chromium.org/634543004/diff/310001/src/core/Sk4x.h#newcode80 src/core/Sk4x.h:80: inline bool Sk4All(Sk4i v) { On 2014/10/10 16:06:11, reed1 ...
6 years, 2 months ago (2014-10-10 21:26:07 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/1030001
6 years, 2 months ago (2014-10-10 23:53:52 UTC) #39
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-10 23:53:54 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/1300001
6 years, 2 months ago (2014-10-15 20:31:44 UTC) #42
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-15 20:31:46 UTC) #43
reed1
https://codereview.chromium.org/634543004/diff/1300001/src/core/SkTileGrid.cpp File src/core/SkTileGrid.cpp (right): https://codereview.chromium.org/634543004/diff/1300001/src/core/SkTileGrid.cpp#newcode135 src/core/SkTileGrid.cpp:135: const int tilesHit = (grid.fRight - grid.fLeft + 1) ...
6 years, 2 months ago (2014-10-15 20:48:12 UTC) #44
mtklein
https://codereview.chromium.org/634543004/diff/1300001/src/core/SkTileGrid.cpp File src/core/SkTileGrid.cpp (right): https://codereview.chromium.org/634543004/diff/1300001/src/core/SkTileGrid.cpp#newcode135 src/core/SkTileGrid.cpp:135: const int tilesHit = (grid.fRight - grid.fLeft + 1) ...
6 years, 2 months ago (2014-10-15 20:55:28 UTC) #45
mtklein
Have a look now Mike? This is a delta off head + https://codereview.chromium.org/658913002/.
6 years, 2 months ago (2014-10-15 21:47:22 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/1410001
6 years, 2 months ago (2014-10-16 17:19:47 UTC) #48
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-16 17:19:49 UTC) #49
mtklein
A comparison run on Nexus 5 (GCC but no SIMD) shows this should be a ...
6 years, 2 months ago (2014-10-16 18:42:33 UTC) #50
mtklein
Added some microbeches and switched intersection back to SkRect::Intersect based off their results: 57M 48 ...
6 years, 2 months ago (2014-10-16 19:24:10 UTC) #51
mtklein
Added some microbeches and switched intersection back to SkRect::Intersect based off their results: 57M 48 ...
6 years, 2 months ago (2014-10-16 19:24:13 UTC) #52
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/1510001
6 years, 2 months ago (2014-10-16 20:40:21 UTC) #54
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-16 20:40:23 UTC) #55
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/1530001
6 years, 2 months ago (2014-10-16 20:51:25 UTC) #57
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-16 20:51:27 UTC) #58
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/95)
6 years, 2 months ago (2014-10-16 20:56:10 UTC) #60
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/1550001
6 years, 2 months ago (2014-10-16 20:59:43 UTC) #62
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-16 20:59:45 UTC) #63
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/97)
6 years, 2 months ago (2014-10-16 21:05:01 UTC) #65
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/1590001
6 years, 2 months ago (2014-10-16 21:27:50 UTC) #67
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 2 months ago (2014-10-16 21:27:51 UTC) #68
commit-bot: I haz the power
Presubmit check for 634543004-1590001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 2 months ago (2014-10-16 21:28:07 UTC) #70
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/1590001
6 years, 2 months ago (2014-10-16 21:30:50 UTC) #72
reed1
lgtm
6 years, 2 months ago (2014-10-16 21:46:25 UTC) #73
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/1430002
6 years, 2 months ago (2014-10-16 22:14:06 UTC) #75
commit-bot: I haz the power
Committed patchset #45 (id:1430002) as 90c7992bfc6330f070f7704d63372a0ec8410170
6 years, 2 months ago (2014-10-16 22:21:48 UTC) #76
mtklein
A revert of this CL (patchset #45 id:1430002) has been created in https://codereview.chromium.org/663663002/ by mtklein@google.com. ...
6 years, 2 months ago (2014-10-16 22:26:23 UTC) #77
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/634543004/1670001
6 years, 2 months ago (2014-10-20 13:48:43 UTC) #79
commit-bot: I haz the power
Committed patchset #48 (id:1670001) as 958e9628d5f9a81aeafa78572cb4afc4b19a455a
6 years, 2 months ago (2014-10-20 14:12:40 UTC) #80
mtklein
6 years, 2 months ago (2014-10-20 17:42:24 UTC) #81
Message was sent while issue was closed.
A revert of this CL (patchset #48 id:1670001) has been created in
https://codereview.chromium.org/637863005/ by mtklein@google.com.

The reason for reverting is: breaks chrome GPU debug bots.

Powered by Google App Engine
This is Rietveld 408576698