Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issue 624453003: Clean up Extension Action Handlers Pt 1/2 (Closed)

Created:
6 years, 2 months ago by Devlin
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, tapted
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Clean up Extension Action Handlers Pt 1/2 Combine ManifestHandlers for PageActions and BrowserActions. Remove support for the uber-deprecated "page_actions" (plural) manifest key. Clean up related tests. TBR=avi@chromium.org (c/b/ui/cocoa) BUG=419475 Committed: https://crrev.com/ba38605aed7c7be61b197bb60ee7c33effdc7dd2 Cr-Commit-Position: refs/heads/master@{#297927}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -288 lines) Patch
M chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller_unittest.mm View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/chrome_common.gypi View 3 chunks +3 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/common/extensions/api/extension_action/browser_action_handler.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/common/extensions/api/extension_action/browser_action_handler.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/common/extensions/api/extension_action/page_action_handler.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/common/extensions/api/extension_action/page_action_handler.cc View 1 chunk +0 lines, -99 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 4 chunks +2 lines, -4 lines 0 comments Download
A chrome/common/extensions/manifest_handlers/extension_action_handler.h View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/common/extensions/manifest_handlers/extension_action_handler.cc View 1 chunk +90 lines, -0 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/init_invalid_page_actions_multi.json View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/test/data/extensions/manifest_tests/init_valid_empty_page_actions.json View 1 chunk +0 lines, -6 lines 0 comments Download
M extensions/common/manifest_constants.h View 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/common/manifest_constants.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Devlin
6 years, 2 months ago (2014-10-01 20:16:09 UTC) #3
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-10-02 20:58:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624453003/20001
6 years, 2 months ago (2014-10-02 21:08:14 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 2af3ab220227e7c5c3d65e627fc6baa69ca833d7
6 years, 2 months ago (2014-10-02 22:33:20 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ba38605aed7c7be61b197bb60ee7c33effdc7dd2 Cr-Commit-Position: refs/heads/master@{#297927}
6 years, 2 months ago (2014-10-02 22:34:00 UTC) #9
tapted
[sheriff] hmm.. could this be the cause of the extension ApiTest failures in http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/31421 ? ...
6 years, 2 months ago (2014-10-03 00:27:07 UTC) #10
Yoyo Zhou
6 years, 2 months ago (2014-10-03 00:53:30 UTC) #11
Message was sent while issue was closed.
On 2014/10/03 00:27:07, tapted wrote:
> [sheriff] hmm.. could this be the cause of the extension ApiTest failures in
>
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28...
> ? I have no idea how though.. but this is the only extensiony thing. might be
a
> debug-build only thing. I think they're crashing. no stacktraces sadly. I'll
see
> if it's a persistent failure..

Nope. There's a lot more failing there than ApiTests, and they look to be timing
out.

Powered by Google App Engine
This is Rietveld 408576698