Clean up Extension Action Handlers Pt 1/2

chrome/common/extensions/api/extension_action/browser_action_handler.cc

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/common/extensions/api/extension_action/browser_action_handler.h"
-
-#include "base/memory/scoped_ptr.h"
-#include "base/strings/utf_string_conversions.h"
-#include "base/values.h"
-#include "chrome/grit/generated_resources.h"
-#include "extensions/common/extension.h"
-#include "extensions/common/feature_switch.h"
-#include "extensions/common/file_util.h"
-#include "extensions/common/manifest.h"
-#include "extensions/common/manifest_constants.h"
-
-namespace extensions {
-
-BrowserActionHandler::BrowserActionHandler() {
-}
-
-BrowserActionHandler::~BrowserActionHandler() {
-}
-
-bool BrowserActionHandler::Parse(Extension* extension,
-                                 base::string16* error) {
-  const base::DictionaryValue* dict = NULL;
-  if (!extension->manifest()->GetDictionary(
-          manifest_keys::kBrowserAction, &dict)) {
-    *error = base::ASCIIToUTF16(manifest_errors::kInvalidBrowserAction);
-    return false;
-  }
-
-  scoped_ptr<ActionInfo> action_info = ActionInfo::Load(extension, dict, error);
-  if (!action_info.get())
-    return false;  // Failed to parse browser action definition.
-
-  ActionInfo::SetBrowserActionInfo(extension, action_info.release());
-
-  return true;
-}
-
-bool BrowserActionHandler::Validate(
-    const Extension* extension,
-    std::string* error,
-    std::vector<InstallWarning>* warnings) const {
-  const ActionInfo* action = ActionInfo::GetBrowserActionInfo(extension);
-  if (action && !action->default_icon.empty() &&
-      !file_util::ValidateExtensionIconSet(
-          action->default_icon,
-          extension,
-          IDS_EXTENSION_LOAD_ICON_FOR_BROWSER_ACTION_FAILED,
-          error)) {
-    return false;
-  }
-  return true;
-}
-
-const std::vector<std::string> BrowserActionHandler::Keys() const {
-  return SingleKey(manifest_keys::kBrowserAction);
-}
-
-}  // namespace extensions