Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 624453003: Clean up Extension Action Handlers Pt 1/2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/i18n/rtl.h" 6 #include "base/i18n/rtl.h"
7 #include "base/path_service.h" 7 #include "base/path_service.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/common/chrome_paths.h" 9 #include "chrome/common/chrome_paths.h"
10 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h" 10 #include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h"
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 Testcase("init_invalid_files_empty.json", errors::kMissingFile), 68 Testcase("init_invalid_files_empty.json", errors::kMissingFile),
69 Testcase("init_invalid_files_js_empty_css_missing.json", 69 Testcase("init_invalid_files_js_empty_css_missing.json",
70 errors::kMissingFile), 70 errors::kMissingFile),
71 Testcase("init_invalid_files_js_item_invalid.json", errors::kInvalidJs), 71 Testcase("init_invalid_files_js_item_invalid.json", errors::kInvalidJs),
72 Testcase("init_invalid_files_css_invalid.json", errors::kInvalidCssList), 72 Testcase("init_invalid_files_css_invalid.json", errors::kInvalidCssList),
73 Testcase("init_invalid_files_css_item_invalid.json", errors::kInvalidCss), 73 Testcase("init_invalid_files_css_item_invalid.json", errors::kInvalidCss),
74 Testcase("init_invalid_permissions_invalid.json", 74 Testcase("init_invalid_permissions_invalid.json",
75 errors::kInvalidPermissions), 75 errors::kInvalidPermissions),
76 Testcase("init_invalid_permissions_item_invalid.json", 76 Testcase("init_invalid_permissions_item_invalid.json",
77 errors::kInvalidPermission), 77 errors::kInvalidPermission),
78 Testcase("init_invalid_page_actions_multi.json",
79 errors::kInvalidPageActionsListSize),
80 Testcase("init_invalid_options_url_invalid.json", 78 Testcase("init_invalid_options_url_invalid.json",
81 errors::kInvalidOptionsPage), 79 errors::kInvalidOptionsPage),
82 Testcase("init_invalid_locale_invalid.json", errors::kInvalidDefaultLocale), 80 Testcase("init_invalid_locale_invalid.json", errors::kInvalidDefaultLocale),
83 Testcase("init_invalid_locale_empty.json", errors::kInvalidDefaultLocale), 81 Testcase("init_invalid_locale_empty.json", errors::kInvalidDefaultLocale),
84 Testcase("init_invalid_min_chrome_invalid.json", 82 Testcase("init_invalid_min_chrome_invalid.json",
85 errors::kInvalidMinimumChromeVersion), 83 errors::kInvalidMinimumChromeVersion),
86 Testcase("init_invalid_chrome_version_too_low.json", 84 Testcase("init_invalid_chrome_version_too_low.json",
87 errors::kChromeVersionTooLow), 85 errors::kChromeVersionTooLow),
88 Testcase("init_invalid_short_name_empty.json", 86 Testcase("init_invalid_short_name_empty.json",
89 errors::kInvalidShortName), 87 errors::kInvalidShortName),
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 OptionsPageInfo::GetOptionsPage(extension.get()).scheme()); 120 OptionsPageInfo::GetOptionsPage(extension.get()).scheme());
123 EXPECT_EQ("/options.html", 121 EXPECT_EQ("/options.html",
124 OptionsPageInfo::GetOptionsPage(extension.get()).path()); 122 OptionsPageInfo::GetOptionsPage(extension.get()).path());
125 123
126 // Test optional short_name field. 124 // Test optional short_name field.
127 extension = LoadAndExpectSuccess("init_valid_short_name.json"); 125 extension = LoadAndExpectSuccess("init_valid_short_name.json");
128 EXPECT_EQ("a very descriptive extension name", extension->name()); 126 EXPECT_EQ("a very descriptive extension name", extension->name());
129 EXPECT_EQ("concise name", extension->short_name()); 127 EXPECT_EQ("concise name", extension->short_name());
130 128
131 Testcase testcases[] = { 129 Testcase testcases[] = {
132 // Test that an empty list of page actions does not stop a browser action
133 // from being loaded.
134 Testcase("init_valid_empty_page_actions.json"),
135
136 // Test with a minimum_chrome_version. 130 // Test with a minimum_chrome_version.
137 Testcase("init_valid_minimum_chrome.json"), 131 Testcase("init_valid_minimum_chrome.json"),
138 132
139 // Test a hosted app with a minimum_chrome_version. 133 // Test a hosted app with a minimum_chrome_version.
140 Testcase("init_valid_app_minimum_chrome.json"), 134 Testcase("init_valid_app_minimum_chrome.json"),
141 135
142 // Test a hosted app with a requirements section. 136 // Test a hosted app with a requirements section.
143 Testcase("init_valid_app_requirements.json"), 137 Testcase("init_valid_app_requirements.json"),
144 138
145 // Verify empty permission settings are considered valid. 139 // Verify empty permission settings are considered valid.
(...skipping 25 matching lines...) Expand all
171 165
172 localized_name = base::WideToUTF16(L"Dictionary (\x05D1\x05D2" L" Google)"); 166 localized_name = base::WideToUTF16(L"Dictionary (\x05D1\x05D2" L" Google)");
173 base::i18n::AdjustStringForLocaleDirection(&localized_name); 167 base::i18n::AdjustStringForLocaleDirection(&localized_name);
174 EXPECT_EQ(localized_name, base::UTF8ToUTF16(extension->name())); 168 EXPECT_EQ(localized_name, base::UTF8ToUTF16(extension->name()));
175 169
176 // Reset locale. 170 // Reset locale.
177 base::i18n::SetICUDefaultLocale(locale); 171 base::i18n::SetICUDefaultLocale(locale);
178 } 172 }
179 173
180 } // namespace extensions 174 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698