Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8070)

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 624453003: Clean up Extension Action Handlers Pt 1/2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc
diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc
index 6807f8a1a3a535542fdbe2e777cbf041eb67765f..5d991bf4d91751977ee709edf2d2f48e3dcb4edd 100644
--- a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc
+++ b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc
@@ -75,8 +75,6 @@ TEST_F(InitValueManifestTest, InitFromValueInvalid) {
errors::kInvalidPermissions),
Testcase("init_invalid_permissions_item_invalid.json",
errors::kInvalidPermission),
- Testcase("init_invalid_page_actions_multi.json",
- errors::kInvalidPageActionsListSize),
Testcase("init_invalid_options_url_invalid.json",
errors::kInvalidOptionsPage),
Testcase("init_invalid_locale_invalid.json", errors::kInvalidDefaultLocale),
@@ -129,10 +127,6 @@ TEST_F(InitValueManifestTest, InitFromValueValid) {
EXPECT_EQ("concise name", extension->short_name());
Testcase testcases[] = {
- // Test that an empty list of page actions does not stop a browser action
- // from being loaded.
- Testcase("init_valid_empty_page_actions.json"),
-
// Test with a minimum_chrome_version.
Testcase("init_valid_minimum_chrome.json"),

Powered by Google App Engine
This is Rietveld 408576698