chrome/chrome_common.gypi - Issue 624453003: Clean up Extension Action Handlers Pt 1/2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_common.gypi

Issue 624453003: Clean up Extension Action Handlers Pt 1/2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_common.gypi

diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi

index 83783c7ef108e9b309ab68411e72988719256c90..71515d26361251377b6d1a0ddd4a0a3d3e6dae9b 100644

--- a/chrome/chrome_common.gypi

+++ b/chrome/chrome_common.gypi

@@ -152,10 +152,6 @@

'common/extensions/api/commands/commands_handler.h',

'common/extensions/api/extension_action/action_info.cc',

'common/extensions/api/extension_action/action_info.h',

- 'common/extensions/api/extension_action/browser_action_handler.cc',

- 'common/extensions/api/extension_action/browser_action_handler.h',

- 'common/extensions/api/extension_action/page_action_handler.cc',

- 'common/extensions/api/extension_action/page_action_handler.h',

'common/extensions/api/file_browser_handlers/file_browser_handler.cc',

'common/extensions/api/file_browser_handlers/file_browser_handler.h',

'common/extensions/api/i18n/default_locale_handler.cc',

@@ -196,6 +192,8 @@

'common/extensions/manifest_handlers/automation.h',

'common/extensions/manifest_handlers/content_scripts_handler.cc',

'common/extensions/manifest_handlers/content_scripts_handler.h',

+ 'common/extensions/manifest_handlers/extension_action_handler.cc',

+ 'common/extensions/manifest_handlers/extension_action_handler.h',

'common/extensions/manifest_handlers/mime_types_handler.cc',

'common/extensions/manifest_handlers/mime_types_handler.h',

'common/extensions/manifest_handlers/minimum_chrome_version_checker.cc',

@@ -446,9 +444,8 @@

'sources!': [

'common/badge_util.cc',

'common/chrome_version_info_posix.cc',

- 'common/extensions/api/extension_action/browser_action_handler.cc',

- 'common/extensions/api/extension_action/page_action_handler.cc',

'common/extensions/api/spellcheck/spellcheck_handler.cc',

+ 'common/extensions/manifest_handlers/extension_action_handler.cc',

'common/extensions/manifest_handlers/minimum_chrome_version_checker.cc',

'common/icon_with_badge_image_source.cc',

'common/media_galleries/metadata_types.h',