Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 618643002: Replace OStream with std::ostream. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne, Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Replace OStream with std::ostream. Committed: https://code.google.com/p/v8/source/detail?r=24319

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : REBASE #

Patch Set 4 : REBASE2 #

Patch Set 5 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+727 lines, -1031 lines) Patch
M src/arm/lithium-arm.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/assembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/assembler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/ast.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/ast.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/basic-block-profiler.h View 1 2 3 chunks +11 lines, -7 lines 0 comments Download
M src/basic-block-profiler.cc View 1 2 3 chunks +17 lines, -15 lines 0 comments Download
M src/code-stubs.h View 22 chunks +26 lines, -25 lines 0 comments Download
M src/code-stubs.cc View 15 chunks +31 lines, -28 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/arm/instruction-selector-arm-unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/basic-block-instrumentor.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download
M src/compiler/change-lowering-unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/common-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M src/compiler/graph-unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/compiler/graph-visualizer.h View 2 chunks +8 lines, -9 lines 0 comments Download
M src/compiler/graph-visualizer.cc View 14 chunks +28 lines, -21 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32-unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/compiler/instruction.h View 1 2 11 chunks +12 lines, -14 lines 0 comments Download
M src/compiler/instruction.cc View 1 2 11 chunks +11 lines, -11 lines 0 comments Download
M src/compiler/instruction-codes.h View 5 chunks +6 lines, -7 lines 0 comments Download
M src/compiler/instruction-selector-unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/js-operator.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/linkage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/linkage.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/compiler/machine-operator.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M src/compiler/machine-operator-unittest.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/compiler/machine-type.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/compiler/machine-type.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/compiler/operator.h View 10 chunks +14 lines, -12 lines 0 comments Download
M src/compiler/pipeline.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M src/compiler/representation-change.h View 2 chunks +6 lines, -4 lines 0 comments Download
M src/compiler/schedule.h View 1 2 3 chunks +8 lines, -6 lines 0 comments Download
M src/compiler/schedule.cc View 1 2 5 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/simplified-operator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-operator.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/compiler/simplified-operator-unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64-unittest.cc View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.h View 1 chunk +1 line, -1 line 0 comments Download
M src/disassembler.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M src/flags.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M src/frames.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M src/gdb-jit.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 8 chunks +10 lines, -9 lines 0 comments Download
M src/hydrogen-dce.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen-gvn.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/hydrogen-gvn.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/hydrogen-instructions.h View 76 chunks +81 lines, -79 lines 0 comments Download
M src/hydrogen-instructions.cc View 44 chunks +103 lines, -77 lines 0 comments Download
M src/hydrogen-types.h View 4 chunks +3 lines, -3 lines 0 comments Download
M src/hydrogen-types.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic-state.h View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ic/ic-state.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/jsregexp.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M src/lithium-codegen.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/log.cc View 5 chunks +9 lines, -7 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 17 chunks +21 lines, -21 lines 0 comments Download
M src/objects.cc View 12 chunks +15 lines, -13 lines 0 comments Download
M src/objects-printer.cc View 50 chunks +79 lines, -73 lines 0 comments Download
M src/ostreams.h View 3 chunks +21 lines, -93 lines 0 comments Download
M src/ostreams.cc View 2 chunks +19 lines, -146 lines 0 comments Download
M src/property.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/property.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/safepoint-table.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/safepoint-table.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/transitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/types.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/types.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/compiler/test-operator.cc View 1 2 3 4 4 chunks +4 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +1 line, -1 line 0 comments Download
D test/cctest/test-ostreams.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M test/cctest/test-regexp.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-09-30 09:49:48 UTC) #2
Yang
On 2014/09/30 09:49:48, Benedikt Meurer wrote: > PTAL lgtm (rubber-stamp)
6 years, 2 months ago (2014-09-30 10:28:39 UTC) #3
Benedikt Meurer
Committed patchset #5 (id:80001) manually as 24319 (presubmit successful).
6 years, 2 months ago (2014-09-30 10:30:36 UTC) #4
Sven Panne
6 years, 2 months ago (2014-09-30 12:09:59 UTC) #5
Message was sent while issue was closed.
lgtm

LGTM (mostly rubber-stamped)

Powered by Google App Engine
This is Rietveld 408576698