|
Revert of Revert of Use the new java_cpp_enum rule in content. (patchset #1 id:1 of https://codereview.chromium.org/625543002/)
Reason for revert:
Oops, wasn't supposed to revert this after all.
Original issue's description:
> Revert of Use the new java_cpp_enum rule in content. (patchset #8 id:140001 of https://codereview.chromium.org/615893003/)
>
> Reason for revert:
> Fails to compile on several bots:
>
> https://chromegw.corp.google.com/i/clank.tot/builders/clang-clankium-tot-builder/builds/56800/steps/compile/logs/stdio
>
> First error:
> FAILED: cd ../../clank/native/framework; python <snip ...>
> ../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/webapps/FullScreenActivityTab.java:28: error: cannot find symbol
> import org.chromium.content.common.TopControlsState;
> ^
> symbol: class TopControlsState
> location: package org.chromium.content.common
>
> Original issue's description:
> > Use the new java_cpp_enum rule in content.
> >
> > This moves most of the generated Java enums under content/ to use the
> > java_cpp_enum rule removing the need for keeping the enums in
> > separate list files and the need for the .template files.
> >
> > BUG= 405532, 351558
> >
> > Committed: https://crrev.com/7d5f0a581ba2f0e79b09ecbf6127ad453a861a96
> > Cr-Commit-Position: refs/heads/master@{#297789}
>
> TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG= 405532, 351558
>
> Committed: https://crrev.com/949b6e5050c7a2ee2a894799db19ec325ba911ef
> Cr-Commit-Position: refs/heads/master@{#297793}
TBR=jam@chromium.org,yfriedman@chromium.org,scottmg@chromium.org,jdduke@chromium.org,brettw@chromium.org,mkosiba@chromium.org,perezju@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= 405532, 351558
Committed: https://crrev.com/4db84b031042bf4f99720372f657ff53e4503a16
Cr-Commit-Position: refs/heads/master@{#297794}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+806 lines, -1117 lines) |
Patch |
|
M |
android_webview/java_library_common.mk
|
View
|
|
1 chunk |
+9 lines, -8 lines |
0 comments
|
Download
|
|
M |
android_webview/libwebviewchromium.gypi
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
build/config/android/rules.gni
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
build/get_landmines.py
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
|
M |
content/browser/android/content_view_core_impl.cc
|
View
|
|
2 chunks |
+27 lines, -20 lines |
0 comments
|
Download
|
|
M |
content/browser/android/gesture_event_type.h
|
View
|
|
1 chunk |
+24 lines, -3 lines |
0 comments
|
Download
|
|
D |
content/browser/android/gesture_event_type_list.h
|
View
|
|
1 chunk |
+0 lines, -33 lines |
0 comments
|
Download
|
|
D |
content/browser/android/popup_item_type_list.h
|
View
|
|
1 chunk |
+0 lines, -23 lines |
0 comments
|
Download
|
|
D |
content/browser/gamepad/canonical_axis_index_list.h
|
View
|
|
1 chunk |
+0 lines, -16 lines |
0 comments
|
Download
|
|
D |
content/browser/gamepad/canonical_button_index_list.h
|
View
|
|
1 chunk |
+0 lines, -28 lines |
0 comments
|
Download
|
|
M |
content/browser/gamepad/gamepad_standard_mappings.h
|
View
|
|
1 chunk |
+29 lines, -23 lines |
0 comments
|
Download
|
|
M |
content/browser/gamepad/gamepad_standard_mappings.cc
|
View
|
|
1 chunk |
+8 lines, -8 lines |
0 comments
|
Download
|
|
M |
content/browser/gamepad/gamepad_standard_mappings_linux.cc
|
View
|
|
2 chunks |
+189 lines, -191 lines |
0 comments
|
Download
|
|
M |
content/browser/gamepad/gamepad_standard_mappings_mac.mm
|
View
|
|
2 chunks |
+233 lines, -245 lines |
0 comments
|
Download
|
|
M |
content/browser/gamepad/gamepad_standard_mappings_win.cc
|
View
|
|
2 chunks |
+89 lines, -94 lines |
0 comments
|
Download
|
|
M |
content/browser/renderer_host/input/selection_event_type.h
|
View
|
|
1 chunk |
+14 lines, -3 lines |
0 comments
|
Download
|
|
D |
content/browser/renderer_host/input/selection_event_type_list.h
|
View
|
|
1 chunk |
+0 lines, -23 lines |
0 comments
|
Download
|
|
M |
content/child/assert_matching_enums.cc
|
View
|
|
1 chunk |
+9 lines, -9 lines |
0 comments
|
Download
|
|
M |
content/content.gyp
|
View
|
|
2 chunks |
+36 lines, -72 lines |
0 comments
|
Download
|
|
M |
content/public/android/BUILD.gn
|
View
|
|
2 chunks |
+20 lines, -85 lines |
0 comments
|
Download
|
|
D |
content/public/android/java/src/org/chromium/content/browser/GestureEventType.template
|
View
|
|
1 chunk |
+0 lines, -13 lines |
0 comments
|
Download
|
|
M |
content/public/android/java/src/org/chromium/content/browser/SpeechRecognition.java
|
View
|
|
5 chunks |
+11 lines, -10 lines |
0 comments
|
Download
|
|
D |
content/public/android/java/src/org/chromium/content/browser/SpeechRecognitionError.template
|
View
|
|
1 chunk |
+0 lines, -11 lines |
0 comments
|
Download
|
|
M |
content/public/android/java/src/org/chromium/content/browser/input/GamepadDevice.java
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
content/public/android/java/src/org/chromium/content/browser/input/GamepadMappings.java
|
View
|
|
5 chunks |
+31 lines, -31 lines |
0 comments
|
Download
|
|
D |
content/public/android/java/src/org/chromium/content/browser/input/SelectionEventType.template
|
View
|
|
1 chunk |
+0 lines, -13 lines |
0 comments
|
Download
|
|
D |
content/public/android/java/src/org/chromium/content/common/ResultCodes.template
|
View
|
|
1 chunk |
+0 lines, -13 lines |
0 comments
|
Download
|
|
D |
content/public/android/java/src/org/chromium/content/common/TopControlsState.template
|
View
|
|
1 chunk |
+0 lines, -12 lines |
0 comments
|
Download
|
|
M |
content/public/common/result_codes.h
|
View
|
|
1 chunk |
+22 lines, -3 lines |
0 comments
|
Download
|
|
D |
content/public/common/result_codes_list.h
|
View
|
|
1 chunk |
+0 lines, -30 lines |
0 comments
|
Download
|
|
M |
content/public/common/screen_orientation_values.h
|
View
|
|
1 chunk |
+11 lines, -3 lines |
0 comments
|
Download
|
|
D |
content/public/common/screen_orientation_values_list.h
|
View
|
|
1 chunk |
+0 lines, -24 lines |
0 comments
|
Download
|
|
M |
content/public/common/speech_recognition_error.h
|
View
|
|
1 chunk |
+27 lines, -3 lines |
0 comments
|
Download
|
|
D |
content/public/common/speech_recognition_error_list.h
|
View
|
|
1 chunk |
+0 lines, -38 lines |
0 comments
|
Download
|
|
M |
content/public/common/top_controls_state.h
|
View
|
|
1 chunk |
+5 lines, -3 lines |
0 comments
|
Download
|
|
D |
content/public/common/top_controls_state_list.h
|
View
|
|
1 chunk |
+0 lines, -19 lines |
0 comments
|
Download
|
|
M |
content/renderer/render_view_impl_android.cc
|
View
|
|
1 chunk |
+6 lines, -3 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|