Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 615393002: Move unit tests to test/unittests. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Move unit tests to test/unittests. As per discussion on the V8 team, this is the place we want them to live, not following the Chrome Style Guide for this. BUG=v8:3489 LOG=y R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24350

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -11352 lines) Patch
M Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M build/all.gyp View 1 chunk +1 line, -4 lines 0 comments Download
M src/DEPS View 1 chunk +1 line, -2 lines 0 comments Download
D src/base/base.gyp View 1 chunk +0 lines, -46 lines 0 comments Download
D src/base/bits-unittest.cc View 1 chunk +0 lines, -167 lines 0 comments Download
D src/base/cpu-unittest.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D src/base/division-by-constant-unittest.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D src/base/flags-unittest.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D src/base/platform/condition-variable-unittest.cc View 1 chunk +0 lines, -301 lines 0 comments Download
D src/base/platform/mutex-unittest.cc View 1 chunk +0 lines, -91 lines 0 comments Download
D src/base/platform/platform-unittest.cc View 1 chunk +0 lines, -110 lines 0 comments Download
D src/base/platform/semaphore-unittest.cc View 1 chunk +0 lines, -145 lines 0 comments Download
D src/base/platform/time-unittest.cc View 1 chunk +0 lines, -186 lines 0 comments Download
D src/base/sys-info-unittest.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D src/base/utils/random-number-generator-unittest.cc View 1 chunk +0 lines, -53 lines 0 comments Download
D src/compiler/arm/instruction-selector-arm-unittest.cc View 1 chunk +0 lines, -1925 lines 0 comments Download
D src/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +0 lines, -1395 lines 0 comments Download
D src/compiler/change-lowering-unittest.cc View 1 chunk +0 lines, -468 lines 0 comments Download
D src/compiler/common-operator-unittest.cc View 1 chunk +0 lines, -183 lines 0 comments Download
D src/compiler/compiler.gyp View 1 chunk +0 lines, -61 lines 0 comments Download
D src/compiler/compiler-test-utils.h View 1 chunk +0 lines, -57 lines 0 comments Download
D src/compiler/graph-reducer-unittest.cc View 1 chunk +0 lines, -115 lines 0 comments Download
D src/compiler/graph-unittest.h View 1 chunk +0 lines, -143 lines 0 comments Download
D src/compiler/graph-unittest.cc View 1 chunk +0 lines, -780 lines 0 comments Download
D src/compiler/ia32/instruction-selector-ia32-unittest.cc View 1 chunk +0 lines, -519 lines 0 comments Download
D src/compiler/instruction-selector-unittest.h View 1 chunk +0 lines, -213 lines 0 comments Download
D src/compiler/instruction-selector-unittest.cc View 1 chunk +0 lines, -518 lines 0 comments Download
D src/compiler/js-builtin-reducer-unittest.cc View 1 chunk +0 lines, -241 lines 0 comments Download
D src/compiler/js-operator-unittest.cc View 1 chunk +0 lines, -152 lines 0 comments Download
D src/compiler/machine-operator-reducer-unittest.cc View 1 chunk +0 lines, -659 lines 0 comments Download
D src/compiler/machine-operator-unittest.cc View 1 1 chunk +0 lines, -312 lines 0 comments Download
D src/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +0 lines, -483 lines 0 comments Download
D src/compiler/simplified-operator-unittest.cc View 1 chunk +0 lines, -215 lines 0 comments Download
D src/compiler/value-numbering-reducer-unittest.cc View 1 chunk +0 lines, -120 lines 0 comments Download
D src/compiler/x64/instruction-selector-x64-unittest.cc View 1 chunk +0 lines, -403 lines 0 comments Download
D src/heap/gc-idle-time-handler-unittest.cc View 1 chunk +0 lines, -348 lines 0 comments Download
D src/heap/heap.gyp View 1 chunk +0 lines, -52 lines 0 comments Download
D src/libplatform/default-platform-unittest.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D src/libplatform/libplatform.gyp View 1 chunk +0 lines, -39 lines 0 comments Download
D src/libplatform/task-queue-unittest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D src/libplatform/worker-thread-unittest.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D src/test/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D src/test/run-all-unittests.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D src/test/test.gyp View 1 chunk +0 lines, -71 lines 0 comments Download
D src/test/test-utils.h View 1 chunk +0 lines, -86 lines 0 comments Download
D src/test/test-utils.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D test/base-unittests/base-unittests.status View 1 chunk +0 lines, -6 lines 0 comments Download
D test/compiler-unittests/compiler-unittests.status View 1 chunk +0 lines, -6 lines 0 comments Download
D test/heap-unittests/heap-unittests.status View 1 chunk +0 lines, -6 lines 0 comments Download
D test/libplatform-unittests/libplatform-unittests.status View 1 chunk +0 lines, -6 lines 0 comments Download
A + test/unittests/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + test/unittests/base/bits-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/base/cpu-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/base/division-by-constant-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/base/flags-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/base/platform/condition-variable-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/base/platform/mutex-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/base/platform/platform-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/base/platform/semaphore-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/base/platform/time-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/base/sys-info-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/base/utils/random-number-generator-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 2 chunks +51 lines, -33 lines 0 comments Download
A + test/unittests/compiler/change-lowering-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/unittests/compiler/common-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/unittests/compiler/compiler-test-utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + test/unittests/compiler/graph-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/unittests/compiler/graph-unittest.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + test/unittests/compiler/graph-unittest.cc View 14 chunks +27 lines, -27 lines 0 comments Download
A + test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc View 4 chunks +10 lines, -10 lines 0 comments Download
A + test/unittests/compiler/instruction-selector-unittest.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + test/unittests/compiler/js-builtin-reducer-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + test/unittests/compiler/js-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/unittests/compiler/machine-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/unittests/compiler/machine-operator-unittest.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/compiler/simplified-operator-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/unittests/compiler/simplified-operator-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/unittests/compiler/value-numbering-reducer-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + test/unittests/heap/gc-idle-time-handler-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/libplatform/default-platform-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/libplatform/task-queue-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/libplatform/worker-thread-unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/run-all-unittests.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + test/unittests/test-utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + test/unittests/test-utils.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/unittests/unittests.gyp View 1 chunk +117 lines, -0 lines 0 comments Download
A + test/unittests/unittests.status View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/presubmit.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/run-tests.py View 2 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-10-01 08:11:43 UTC) #2
Sven Panne
LGTM (rubberstamped)
6 years, 2 months ago (2014-10-01 08:30:05 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-10-01 08:35:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24350 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698