Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 614323003: DevTools: enable by default disableAgentsWhenProfile experiment (Closed)

Created:
6 years, 2 months ago by loislo
Modified:
6 years, 1 month ago
Reviewers:
aandrey, pfeldman, yurys, sergeyv
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: enable by default disableAgentsWhenProfile experiment profilingLock was replaced with WebInspector.targetManager.suspendAllTargets/resumeAllTargets calls and TargetManager.Events.SuspendStateChanged event. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183942

Patch Set 1 : refactored #

Patch Set 2 : small change #

Total comments: 20

Patch Set 3 : comments addressed #

Patch Set 4 : tests were fixed #

Patch Set 5 : unnecessary line was removed #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -118 lines) Patch
A LayoutTests/inspector/profiler/agents-disabled-check.html View 1 chunk +42 lines, -0 lines 0 comments Download
A LayoutTests/inspector/profiler/agents-disabled-check-expected.txt View 1 chunk +19 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 2 3 3 chunks +2 lines, -8 lines 0 comments Download
M Source/devtools/devtools.gypi View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/audits/AuditLauncherView.js View 1 2 3 4 3 chunks +3 lines, -9 lines 0 comments Download
M Source/devtools/front_end/components/InspectorView.js View 1 2 3 4 2 chunks +7 lines, -5 lines 0 comments Download
M Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 2 3 4 4 chunks +7 lines, -6 lines 1 comment Download
M Source/devtools/front_end/main/Main.js View 1 2 3 4 2 chunks +6 lines, -1 line 0 comments Download
M Source/devtools/front_end/profiler/CanvasProfileView.js View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/profiler/ProfilesPanel.js View 1 2 3 4 4 chunks +5 lines, -8 lines 0 comments Download
M Source/devtools/front_end/screencast/ScreencastView.js View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/CSSStyleModel.js View 2 chunks +9 lines, -11 lines 0 comments Download
M Source/devtools/front_end/sdk/DOMModel.js View 4 2 chunks +7 lines, -8 lines 0 comments Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 1 2 5 chunks +15 lines, -17 lines 0 comments Download
D Source/devtools/front_end/sdk/Locks.js View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/devtools/front_end/sdk/Target.js View 1 2 3 2 chunks +59 lines, -1 line 0 comments Download
M Source/devtools/front_end/sdk/TimelineManager.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/sdk/TracingManager.js View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/devtools/front_end/sdk/WorkerTargetManager.js View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M Source/devtools/front_end/sdk/module.json View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 2 3 4 5 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 36 (14 generated)
loislo
6 years, 2 months ago (2014-10-01 08:35:41 UTC) #2
loislo
ptal
6 years, 2 months ago (2014-10-13 11:53:04 UTC) #3
loislo
ptal
6 years, 2 months ago (2014-10-14 14:42:33 UTC) #8
loislo
+aandrey@ +sergeyv@
6 years, 2 months ago (2014-10-14 14:52:54 UTC) #11
yurys
https://codereview.chromium.org/614323003/diff/130001/Source/devtools/front_end/profiler/CanvasProfileView.js File Source/devtools/front_end/profiler/CanvasProfileView.js (right): https://codereview.chromium.org/614323003/diff/130001/Source/devtools/front_end/profiler/CanvasProfileView.js#newcode729 Source/devtools/front_end/profiler/CanvasProfileView.js:729: WebInspector.targetManager.suspendAllTargets(); Do we really need this call here? https://codereview.chromium.org/614323003/diff/130001/Source/devtools/front_end/profiler/ProfilesPanel.js ...
6 years, 2 months ago (2014-10-15 14:07:34 UTC) #12
loislo
https://codereview.chromium.org/614323003/diff/130001/Source/devtools/front_end/profiler/CanvasProfileView.js File Source/devtools/front_end/profiler/CanvasProfileView.js (right): https://codereview.chromium.org/614323003/diff/130001/Source/devtools/front_end/profiler/CanvasProfileView.js#newcode729 Source/devtools/front_end/profiler/CanvasProfileView.js:729: WebInspector.targetManager.suspendAllTargets(); On 2014/10/15 14:07:34, yurys wrote: > Do we ...
6 years, 2 months ago (2014-10-15 15:38:47 UTC) #13
aandrey
https://codereview.chromium.org/614323003/diff/130001/Source/devtools/front_end/profiler/CanvasProfileView.js File Source/devtools/front_end/profiler/CanvasProfileView.js (right): https://codereview.chromium.org/614323003/diff/130001/Source/devtools/front_end/profiler/CanvasProfileView.js#newcode729 Source/devtools/front_end/profiler/CanvasProfileView.js:729: WebInspector.targetManager.suspendAllTargets(); On 2014/10/15 15:38:47, loislo wrote: > On 2014/10/15 ...
6 years, 2 months ago (2014-10-15 18:14:06 UTC) #14
loislo
https://codereview.chromium.org/614323003/diff/130001/Source/devtools/front_end/profiler/CanvasProfileView.js File Source/devtools/front_end/profiler/CanvasProfileView.js (right): https://codereview.chromium.org/614323003/diff/130001/Source/devtools/front_end/profiler/CanvasProfileView.js#newcode737 Source/devtools/front_end/profiler/CanvasProfileView.js:737: WebInspector.targetManager.suspendAllTargets(); On 2014/10/15 18:14:06, aandrey wrote: > This name ...
6 years, 2 months ago (2014-10-16 09:08:22 UTC) #15
aandrey
https://codereview.chromium.org/614323003/diff/130001/Source/devtools/front_end/profiler/CanvasProfileView.js File Source/devtools/front_end/profiler/CanvasProfileView.js (right): https://codereview.chromium.org/614323003/diff/130001/Source/devtools/front_end/profiler/CanvasProfileView.js#newcode737 Source/devtools/front_end/profiler/CanvasProfileView.js:737: WebInspector.targetManager.suspendAllTargets(); On 2014/10/16 09:08:22, loislo wrote: > On 2014/10/15 ...
6 years, 2 months ago (2014-10-16 09:49:41 UTC) #16
loislo
On 2014/10/16 09:49:41, aandrey wrote: > https://codereview.chromium.org/614323003/diff/130001/Source/devtools/front_end/profiler/CanvasProfileView.js > File Source/devtools/front_end/profiler/CanvasProfileView.js (right): > > https://codereview.chromium.org/614323003/diff/130001/Source/devtools/front_end/profiler/CanvasProfileView.js#newcode737 > ...
6 years, 2 months ago (2014-10-16 11:34:08 UTC) #17
aandrey
OK, my lgtm on naming
6 years, 2 months ago (2014-10-16 12:00:29 UTC) #18
yurys
lgtm
6 years, 2 months ago (2014-10-16 12:13:10 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614323003/150001
6 years, 2 months ago (2014-10-16 12:20:11 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/29498)
6 years, 2 months ago (2014-10-16 13:39:24 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614323003/150001
6 years, 2 months ago (2014-10-16 13:53:09 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/29513)
6 years, 2 months ago (2014-10-16 14:52:39 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614323003/170001
6 years, 2 months ago (2014-10-18 07:18:57 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/29823)
6 years, 2 months ago (2014-10-18 08:18:29 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/614323003/190001
6 years, 2 months ago (2014-10-18 10:50:28 UTC) #33
commit-bot: I haz the power
Committed patchset #5 (id:190001) as 183942
6 years, 2 months ago (2014-10-18 11:52:55 UTC) #34
pfeldman
https://codereview.chromium.org/614323003/diff/190001/Source/devtools/front_end/elements/ElementsTreeOutline.js File Source/devtools/front_end/elements/ElementsTreeOutline.js (right): https://codereview.chromium.org/614323003/diff/190001/Source/devtools/front_end/elements/ElementsTreeOutline.js#newcode1274 Source/devtools/front_end/elements/ElementsTreeOutline.js:1274: if (!children || this._updateChildrenInProgress || !this.treeOutline._visible) Could reviewers explain ...
6 years, 1 month ago (2014-11-12 17:19:39 UTC) #35
yurys
6 years, 1 month ago (2014-11-13 10:01:17 UTC) #36
Message was sent while issue was closed. 
On 2014/11/12 17:19:39, pfeldman wrote:
>
https://codereview.chromium.org/614323003/diff/190001/Source/devtools/front_e...
> File Source/devtools/front_end/elements/ElementsTreeOutline.js (right):
> 
>
https://codereview.chromium.org/614323003/diff/190001/Source/devtools/front_e...
> Source/devtools/front_end/elements/ElementsTreeOutline.js:1274: if (!children
||
> this._updateChildrenInProgress || !this.treeOutline._visible)
> Could reviewers explain why this is needed here?

Sure, the change slipped into the patch after our reviews as we lgtm'ed it 3
weeks, 6 days ago and the change first appeared in patch set 4 uploaded 3 weeks,
5 days ago.

Powered by Google App Engine
This is Rietveld 408576698