Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1492)

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 614323003: DevTools: enable by default disableAgentsWhenProfile experiment (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: unnecessary line was removed Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelinePanel.js
diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js
index 2efd473b2b301cb40bdda398635a73ee98ed2b6c..7d1896d58fc003cd5ad7a96c0da94f84f868ddc0 100644
--- a/Source/devtools/front_end/timeline/TimelinePanel.js
+++ b/Source/devtools/front_end/timeline/TimelinePanel.js
@@ -123,7 +123,7 @@ WebInspector.TimelinePanel = function()
this._onModeChanged();
this._detailsSplitView.show(this.element);
- WebInspector.profilingLock().addEventListener(WebInspector.Lock.Events.StateChanged, this._onProfilingStateChanged, this);
+ WebInspector.targetManager.addEventListener(WebInspector.TargetManager.Events.SuspendStateChanged, this._onSuspendStateChanged, this);
}
WebInspector.TimelinePanel.OverviewMode = {
@@ -636,7 +636,6 @@ WebInspector.TimelinePanel.prototype = {
uiControl.label.classList.toggle("dimmed", !enabled);
}
this._recordingOptionUIControls.forEach(handler);
- WebInspector.inspectorView.setCurrentPanelLocked(!enabled);
},
/**
@@ -672,7 +671,7 @@ WebInspector.TimelinePanel.prototype = {
this._setUIControlsEnabled(true);
},
- _onProfilingStateChanged: function()
+ _onSuspendStateChanged: function()
{
this._updateToggleTimelineButton(this.toggleTimelineButton.toggled);
},
@@ -682,7 +681,6 @@ WebInspector.TimelinePanel.prototype = {
*/
_updateToggleTimelineButton: function(toggled)
{
- var isAcquiredInSomeTarget = WebInspector.profilingLock().isAcquired();
this.toggleTimelineButton.toggled = toggled;
if (toggled) {
this.toggleTimelineButton.title = WebInspector.UIString("Stop");
@@ -690,7 +688,7 @@ WebInspector.TimelinePanel.prototype = {
} else if (this._stopPending) {
this.toggleTimelineButton.title = WebInspector.UIString("Stop pending");
this.toggleTimelineButton.setEnabled(false);
- } else if (isAcquiredInSomeTarget) {
+ } else if (WebInspector.targetManager.allTargetsSuspended()) {
this.toggleTimelineButton.title = WebInspector.anotherProfilerActiveLabel();
this.toggleTimelineButton.setEnabled(false);
} else {

Powered by Google App Engine
This is Rietveld 408576698