Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1886)

Unified Diff: Source/devtools/front_end/sdk/WorkerTargetManager.js

Issue 614323003: DevTools: enable by default disableAgentsWhenProfile experiment (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: unnecessary line was removed Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/WorkerTargetManager.js
diff --git a/Source/devtools/front_end/sdk/WorkerTargetManager.js b/Source/devtools/front_end/sdk/WorkerTargetManager.js
index 3f1ca35951b8905afd0b5a462851c07e440fcbad..9215cb608709d194b33868790b87dea6b912a008 100644
--- a/Source/devtools/front_end/sdk/WorkerTargetManager.js
+++ b/Source/devtools/front_end/sdk/WorkerTargetManager.js
@@ -14,17 +14,19 @@ WebInspector.WorkerTargetManager = function(mainTarget, targetManager)
this._targetManager = targetManager;
mainTarget.workerManager.addEventListener(WebInspector.WorkerManager.Events.WorkerAdded, this._onWorkerAdded, this);
mainTarget.workerManager.addEventListener(WebInspector.WorkerManager.Events.WorkersCleared, this._onWorkersCleared, this);
- WebInspector.profilingLock().addEventListener(WebInspector.Lock.Events.StateChanged, this._onProfilingStateChanged, this);
- this._onProfilingStateChanged();
+ WebInspector.targetManager.addEventListener(WebInspector.TargetManager.Events.SuspendStateChanged, this._onSuspendStateChanged, this);
+ this._onSuspendStateChanged();
this._lastAnonymousTargetId = 0;
this._shouldPauseWorkerOnStart = WebInspector.isWorkerFrontend();
}
WebInspector.WorkerTargetManager.prototype = {
- _onProfilingStateChanged: function()
+ _onSuspendStateChanged: function()
{
- var acquired = WebInspector.profilingLock().isAcquired();
- this._mainTarget.workerAgent().setAutoconnectToWorkers(!acquired);
+ // FIXME: the logic needs to be extended and cover the case when a worker was started after disabling autoconnect
+ // and still alive after enabling autoconnect.
+ var suspended = WebInspector.targetManager.allTargetsSuspended();
+ this._mainTarget.workerAgent().setAutoconnectToWorkers(!suspended);
},
/**

Powered by Google App Engine
This is Rietveld 408576698