Source/devtools/front_end/sdk/TimelineManager.js - Issue 614323003: DevTools: enable by default disableAgentsWhenProfile experiment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sdk/TimelineManager.js

Issue 614323003: DevTools: enable by default disableAgentsWhenProfile experiment (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: unnecessary line was removed Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/sdk/TimelineManager.js

diff --git a/Source/devtools/front_end/sdk/TimelineManager.js b/Source/devtools/front_end/sdk/TimelineManager.js

index 6bbc0ee944924ab89fa91219f02d739d899f9b6f..d81c1e191f8dffa6568167439dfe5de39dddc3ea 100644

--- a/Source/devtools/front_end/sdk/TimelineManager.js

+++ b/Source/devtools/front_end/sdk/TimelineManager.js

@@ -67,7 +67,7 @@ WebInspector.TimelineManager.prototype = {

start: function(maxCallStackDepth, liveEvents, includeCounters, includeGPUEvents, callback)

{

this._enablementCount++;

- WebInspector.profilingLock().acquire();

+ WebInspector.targetManager.suspendAllTargets();

if (this._enablementCount === 1)

this.target().timelineAgent().start(maxCallStackDepth, true, liveEvents, includeCounters, includeGPUEvents, callback);

else if (callback)

@@ -93,7 +93,7 @@ WebInspector.TimelineManager.prototype = {

function allDoneCallback(error)

{

- WebInspector.profilingLock().release();

+ WebInspector.targetManager.resumeAllTargets();

callback(error);

}