Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: Source/devtools/front_end/sdk/TracingManager.js

Issue 614323003: DevTools: enable by default disableAgentsWhenProfile experiment (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: unnecessary line was removed Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/TracingManager.js
diff --git a/Source/devtools/front_end/sdk/TracingManager.js b/Source/devtools/front_end/sdk/TracingManager.js
index 3b4300031cd61fe71109046ab2bccdefb8bb8170..0d31cb9882d275ce639cdf86524a202c1aa6a2f5 100644
--- a/Source/devtools/front_end/sdk/TracingManager.js
+++ b/Source/devtools/front_end/sdk/TracingManager.js
@@ -91,8 +91,7 @@ WebInspector.TracingManager.prototype = {
{
if (this._active)
return;
- WebInspector.profilingLock().acquire();
- this._shouldReleaseLock = true;
+ WebInspector.targetManager.suspendAllTargets();
var bufferUsageReportingIntervalMs = 500;
TracingAgent.start(categoryFilter, options, bufferUsageReportingIntervalMs, callback);
this._active = true;
@@ -104,10 +103,7 @@ WebInspector.TracingManager.prototype = {
if (!this._active)
return;
TracingAgent.end(this._onStop.bind(this));
- if (this._shouldReleaseLock) {
- this._shouldReleaseLock = false;
- WebInspector.profilingLock().release();
- }
+ WebInspector.targetManager.resumeAllTargets();
},
_onStop: function()

Powered by Google App Engine
This is Rietveld 408576698