components/autofill/core/common/password_form_fill_data.cc - Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/password_form_fill_data.cc

Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review inputs. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/form_data.h ('K') | « components/autofill/core/common/form_data_unittest.cc ('k') | components/password_manager/core/browser/password_autofill_manager.cc » ('j') | components/password_manager/core/browser/password_form_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/password_form_fill_data.cc

diff --git a/components/autofill/core/common/password_form_fill_data.cc b/components/autofill/core/common/password_form_fill_data.cc

index 7dbc97d0ab62b42dc7b158bcea47b663d7fcd149..a8383d70eaa90f3d6120028074d35cfceab26453 100644

--- a/components/autofill/core/common/password_form_fill_data.cc

+++ b/components/autofill/core/common/password_form_fill_data.cc

@@ -50,8 +50,8 @@ void InitPasswordFormFillData(

// Fill basic form data.

result->basic_data.origin = form_on_page.origin;

result->basic_data.action = form_on_page.action;

Ilya Sherman 2014/10/13 23:49:32 It looks like this class really shouldn't depend o

Pritam Nikam 2014/10/16 12:55:13 Sure, I'll take care this in next patch set. Still

- result->basic_data.fields.push_back(username_field);

- result->basic_data.fields.push_back(password_field);

+ result->basic_data.username = username_field;

+ result->basic_data.password = password_field;

result->wait_for_username = wait_for_username_before_autofill;

result->preferred_realm = preferred_match->original_signon_realm;