components/autofill/core/common/form_data_unittest.cc - Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/form_data_unittest.cc

Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review inputs. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/form_data.h ('K') | « components/autofill/core/common/form_data.cc ('k') | components/autofill/core/common/password_form_fill_data.cc » ('j') | components/autofill/core/common/password_form_fill_data.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/form_data_unittest.cc

diff --git a/components/autofill/core/common/form_data_unittest.cc b/components/autofill/core/common/form_data_unittest.cc

index 4f57129e682f62218c1069f444833275f47badaa..4e3b4bfeb9d934e16d426edf3d801a8914a8d504 100644

--- a/components/autofill/core/common/form_data_unittest.cc

+++ b/components/autofill/core/common/form_data_unittest.cc

@@ -23,6 +23,8 @@ void SerializeInVersion1Format(const autofill::FormData& form_data,

pickle->WriteString(form_data.origin.spec());

pickle->WriteString(form_data.action.spec());

pickle->WriteBool(form_data.user_submitted);

+ SerializeFormFieldData(form_data.username, pickle);

+ SerializeFormFieldData(form_data.password, pickle);

pickle->WriteInt(static_cast<int>(form_data.fields.size()));

for (size_t i = 0; i < form_data.fields.size(); ++i) {

SerializeFormFieldData(form_data.fields[i], pickle);

@@ -37,6 +39,8 @@ void SerializeIncorrectFormat(const autofill::FormData& form_data,