Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: components/autofill/core/common/form_data.h

Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review inputs. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/common/form_data.h
diff --git a/components/autofill/core/common/form_data.h b/components/autofill/core/common/form_data.h
index ffbc204b61bc864b2571619bbf780db71c57c21a..e4c9a7b1aee6cbe27c7417363f1d1cd37a78b92a 100644
--- a/components/autofill/core/common/form_data.h
+++ b/components/autofill/core/common/form_data.h
@@ -35,6 +35,14 @@ struct FormData {
GURL action;
// true if this form was submitted by a user gesture and not javascript.
bool user_submitted;
+
+ // Password form input fields.
+ FormFieldData username;
vabr (Chromium) 2014/10/13 12:30:53 nit: rename to username_field, password_field
Pritam Nikam 2014/10/16 12:55:13 Done.
+ FormFieldData password;
+
+ // TODO (pritam.nikam): Make sure we remove |fields|, and add form fields
+ // for all possible autofillable input fields.
vabr (Chromium) 2014/10/13 12:30:53 Please add a reference to http://crbug.com/417295.
Pritam Nikam 2014/10/16 12:55:13 Done.
+
// A vector of all the input fields in the form.
std::vector<FormFieldData> fields;
};

Powered by Google App Engine
This is Rietveld 408576698