[Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

components/autofill/core/common/password_form_fill_data.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/common/password_form_fill_data.h"
 
 #include "base/logging.h"
 #include "base/strings/utf_string_conversions.h"
 #include "components/autofill/core/common/form_field_data.h"
 
@@ skipping 31 matching lines @@
   FormFieldData username_field;
   username_field.name = form_on_page.username_element;
   username_field.value = preferred_match->username_value;
   FormFieldData password_field;
   password_field.name = form_on_page.password_element;
   password_field.value = preferred_match->password_value;
   password_field.form_control_type = "password";
 
   // Fill basic form data.
   result->basic_data.origin = form_on_page.origin;
   result->basic_data.action = form_on_page.action;

[Ilya Sherman, 2014/10/13 23:49:32]

It looks like this class really shouldn't depend on FormData at all.  Instead,
it should just have its own origin and action member fields.

[Pritam Nikam, 2014/10/16 12:55:13]

Sure, I'll take care this in next patch set.
Still WIP.

-  result->basic_data.fields.push_back(username_field);
-  result->basic_data.fields.push_back(password_field);
+  result->basic_data.username = username_field;
+  result->basic_data.password = password_field;
   result->wait_for_username = wait_for_username_before_autofill;
 
   result->preferred_realm = preferred_match->original_signon_realm;
 
   // Copy additional username/value pairs.
   PasswordFormMap::const_iterator iter;
   for (iter = matches.begin(); iter != matches.end(); iter++) {
     if (iter->second != preferred_match) {
       PasswordAndRealm value;
       value.password = iter->second->password_value;
@@ skipping 10 matching lines @@
       key.username = iter->first;
       key.password = iter->second->password_value;
       key.realm = iter->second->original_signon_realm;
       result->other_possible_usernames[key] =
           iter->second->other_possible_usernames;
     }
   }
 }
 
 }  // namespace autofill