components/password_manager/core/browser/password_form_manager.cc - Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 614023002: [Password manager] Relplace the FormFieldData vector from autofill::FormData with named fields… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated review inputs. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/core/common/password_form_fill_data.cc ('K') | « components/password_manager/core/browser/password_autofill_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager.cc

diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc

index 59eff7cc5235d839e224c9b1fa90916d4553389f..d4277dabb917a66388ee30e0a22bc224f1bc5598 100644

--- a/components/password_manager/core/browser/password_form_manager.cc

+++ b/components/password_manager/core/browser/password_form_manager.cc

@@ -710,7 +710,7 @@ void PasswordFormManager::CheckForAccountCreationForm(

// to PasswordForm. Even without this check, these FormStructure's won't

// be uploaded, but it makes it hard to see if we are encountering

// unexpected errors.

- if (!pending.form_data.fields.empty() &&

+ if (!pending.form_data.password.name.empty() &&

vabr (Chromium) 2014/10/13 12:30:53 This seems like a change in behaviour -- what abou

Pritam Nikam 2014/10/16 12:55:13 Done.

pending_structure.FormSignature() !=

observed_structure.FormSignature()) {

UploadPasswordForm(pending.form_data,