Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 611563002: GuestView: Use Weak Pointers Throughout (Closed)

Created:
6 years, 2 months ago by Fady Samuel
Modified:
6 years, 2 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GuestView: Use Weak Pointers Throughout BUG=none Committed: https://crrev.com/c57b428d491f1b9a27bd352f3e11fe304b101e2a Cr-Commit-Position: refs/heads/master@{#298328}

Patch Set 1 #

Patch Set 2 : Remove commented out code #

Patch Set 3 : Merge with ToT #

Patch Set 4 : Rebased #

Patch Set 5 : Fixed bug where openers become NULL before WillDestroy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -19 lines) Patch
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/guest_view/guest_view_base.cc View 1 2 3 4 5 chunks +8 lines, -6 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_view_guest.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Fady Samuel
6 years, 2 months ago (2014-09-26 19:05:54 UTC) #2
lazyboy
lgtm
6 years, 2 months ago (2014-09-26 19:09:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611563002/20001
6 years, 2 months ago (2014-09-26 19:14:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/18413)
6 years, 2 months ago (2014-09-26 20:26:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611563002/80001
6 years, 2 months ago (2014-10-06 19:25:02 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 01:42:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/611563002/80001
6 years, 2 months ago (2014-10-07 02:00:01 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 67a52086bfcb5aadc2c492167901bd6b1a1a6d98
6 years, 2 months ago (2014-10-07 02:23:26 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 02:24:07 UTC) #15
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/c57b428d491f1b9a27bd352f3e11fe304b101e2a
Cr-Commit-Position: refs/heads/master@{#298328}

Powered by Google App Engine
This is Rietveld 408576698