extensions/browser/guest_view/guest_view_base.h - Issue 611563002: GuestView: Use Weak Pointers Throughout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/guest_view_base.h

Issue 611563002: GuestView: Use Weak Pointers Throughout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed bug where openers become NULL before WillDestroy Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/guest_view_base.h

diff --git a/extensions/browser/guest_view/guest_view_base.h b/extensions/browser/guest_view/guest_view_base.h

index 5fa901319f82b01088622e0381d4c073001f10d5..b881309d16b034d0f9b3e0d86a0f3cba089fbcb7 100644

--- a/extensions/browser/guest_view/guest_view_base.h

+++ b/extensions/browser/guest_view/guest_view_base.h

@@ -185,8 +185,6 @@ class GuestViewBase : public content::BrowserPluginGuestDelegate,

const gfx::Size& min_size,

const gfx::Size& max_size);

- base::WeakPtr<GuestViewBase> AsWeakPtr();

bool initialized() const { return initialized_; }

content::WebContents* embedder_web_contents() const {