chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc - Issue 611563002: GuestView: Use Weak Pointers Throughout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

Issue 611563002: GuestView: Use Weak Pointers Throughout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed bug where openers become NULL before WillDestroy Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h ('k') | chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

index 428b72a55b36cc37f0c7715385d60f6865fd2643..79eb3ce000e017acde6e100103da1d16a18bc86f 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc

@@ -31,7 +31,8 @@ ChromeWebViewGuestDelegate::ChromeWebViewGuestDelegate(

: pending_context_menu_request_id_(0),

chromevox_injected_(false),

current_zoom_factor_(1.0),

- web_view_guest_(web_view_guest) {

+ web_view_guest_(web_view_guest),

+ weak_ptr_factory_(this) {

}

ChromeWebViewGuestDelegate::~ChromeWebViewGuestDelegate() {

@@ -123,7 +124,7 @@ void ChromeWebViewGuestDelegate::OnDidInitialize() {

CHECK(accessibility_manager);

accessibility_subscription_ = accessibility_manager->RegisterCallback(

base::Bind(&ChromeWebViewGuestDelegate::OnAccessibilityStatusChanged,

- base::Unretained(this)));

+ weak_ptr_factory_.GetWeakPtr()));

#endif

}