extensions/browser/guest_view/web_view/web_view_guest.h - Issue 611563002: GuestView: Use Weak Pointers Throughout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.h

Issue 611563002: GuestView: Use Weak Pointers Throughout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed bug where openers become NULL before WillDestroy Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/guest_view/web_view/web_view_guest.h

diff --git a/extensions/browser/guest_view/web_view/web_view_guest.h b/extensions/browser/guest_view/web_view/web_view_guest.h

index 9b9c702ec9828e1f9ca7b2476e546ca4b2d9615e..63cf7503c7d60c29cd2b44de144350606150fc00 100644

--- a/extensions/browser/guest_view/web_view/web_view_guest.h

+++ b/extensions/browser/guest_view/web_view/web_view_guest.h

@@ -369,6 +369,10 @@ class WebViewGuest : public GuestView<WebViewGuest>,

typedef std::map<WebViewGuest*, NewWindowInfo> PendingWindowMap;

PendingWindowMap pending_new_windows_;

+ // This is used to ensure pending tasks will not fire after this object is

+ // destroyed.

+ base::WeakPtrFactory<WebViewGuest> weak_ptr_factory_;

DISALLOW_COPY_AND_ASSIGN(WebViewGuest);

};