chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc - Issue 611563002: GuestView: Use Weak Pointers Throughout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

Issue 611563002: GuestView: Use Weak Pointers Throughout (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed bug where openers become NULL before WillDestroy Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.cc ('k') | extensions/browser/guest_view/guest_view_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

diff --git a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

index 71c33fa6dcb2f9524f5c19a5fe88fc9c27266d29..1acc8a381f2bec353da2e7ee48f77aec4ef4e648 100644

--- a/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

+++ b/chrome/browser/guest_view/web_view/chrome_web_view_permission_helper_delegate.cc

@@ -136,7 +136,7 @@ void ChromeWebViewPermissionHelperDelegate::CanDownload(

request_info,

base::Bind(

&ChromeWebViewPermissionHelperDelegate::OnDownloadPermissionResponse,

- base::Unretained(this),

+ weak_factory_.GetWeakPtr(),

callback),

false /* allowed_by_default */);

}

@@ -164,7 +164,7 @@ void ChromeWebViewPermissionHelperDelegate::RequestPointerLockPermission(

request_info,

base::Bind(&ChromeWebViewPermissionHelperDelegate::

OnPointerLockPermissionResponse,

- base::Unretained(this),

+ weak_factory_.GetWeakPtr(),

callback),

false /* allowed_by_default */);

}

@@ -192,7 +192,7 @@ void ChromeWebViewPermissionHelperDelegate::RequestGeolocationPermission(

permission_callback =

base::Bind(&ChromeWebViewPermissionHelperDelegate::

OnGeolocationPermissionResponse,

- base::Unretained(this),

+ weak_factory_.GetWeakPtr(),

bridge_id,

user_gesture,

callback);

@@ -274,7 +274,7 @@ void ChromeWebViewPermissionHelperDelegate::RequestFileSystemPermission(

request_info,

base::Bind(&ChromeWebViewPermissionHelperDelegate::

OnFileSystemPermissionResponse,

- base::Unretained(this),

+ weak_factory_.GetWeakPtr(),

callback),

allowed_by_default);

}

@@ -297,7 +297,7 @@ void ChromeWebViewPermissionHelperDelegate::FileSystemAccessedAsync(

!blocked_by_policy,

base::Bind(&ChromeWebViewPermissionHelperDelegate::

FileSystemAccessedAsyncResponse,

- base::Unretained(this),

+ weak_factory_.GetWeakPtr(),

render_process_id,

render_frame_id,

request_id,

@@ -327,7 +327,7 @@ void ChromeWebViewPermissionHelperDelegate::FileSystemAccessedSync(

!blocked_by_policy,

base::Bind(&ChromeWebViewPermissionHelperDelegate::

FileSystemAccessedSyncResponse,

- base::Unretained(this),

+ weak_factory_.GetWeakPtr(),

render_process_id,

render_frame_id,

url,