Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 606473002: Remove implicit HANDLE conversions from chrome. (Closed)

Created:
6 years, 2 months ago by rvargas (doing something else)
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, grt+watch_chromium.org, wfh+watch_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit HANDLE conversions from chrome. BUG=416722 R=thestig@chromium.org Committed: https://crrev.com/d7743bab4d428ef413320f9e71ed08b62255573b Cr-Commit-Position: refs/heads/master@{#296613}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove spurious file and fix indent (+rebase) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -50 lines) Patch
M chrome/app/image_pre_reader_win.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/image_writer_private/removable_storage_provider_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/first_run/upgrade_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/memory_details_win.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/process_singleton_win.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M chrome/common/service_process_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/gcapi/gcapi.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/setup/setup_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/installer/setup/setup_util_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/installer/setup/uninstall.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/util/google_update_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/user_experiment.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cdd_conversion_win.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M chrome/utility/image_writer/image_writer_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/ie_importer_win.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
rvargas (doing something else)
6 years, 2 months ago (2014-09-24 23:04:33 UTC) #1
Lei Zhang
https://codereview.chromium.org/606473002/diff/1/chrome/browser/search_engines/prepopulated_engines.xml File chrome/browser/search_engines/prepopulated_engines.xml (right): https://codereview.chromium.org/606473002/diff/1/chrome/browser/search_engines/prepopulated_engines.xml#newcode1 chrome/browser/search_engines/prepopulated_engines.xml:1: <?xml version="1.0" encoding="utf-8"?> Is this suppose to be here?
6 years, 2 months ago (2014-09-24 23:08:22 UTC) #2
Lei Zhang
lgtm with prepopulated_engines.xml removed? https://codereview.chromium.org/606473002/diff/1/chrome/installer/util/user_experiment.cc File chrome/installer/util/user_experiment.cc (right): https://codereview.chromium.org/606473002/diff/1/chrome/installer/util/user_experiment.cc#newcode88 chrome/installer/util/user_experiment.cc:88: FileTimeToHours(time) : -1; nit: indent ...
6 years, 2 months ago (2014-09-24 23:10:10 UTC) #3
rvargas (doing something else)
Thanks! https://codereview.chromium.org/606473002/diff/1/chrome/browser/search_engines/prepopulated_engines.xml File chrome/browser/search_engines/prepopulated_engines.xml (right): https://codereview.chromium.org/606473002/diff/1/chrome/browser/search_engines/prepopulated_engines.xml#newcode1 chrome/browser/search_engines/prepopulated_engines.xml:1: <?xml version="1.0" encoding="utf-8"?> On 2014/09/24 23:08:22, Lei Zhang ...
6 years, 2 months ago (2014-09-24 23:58:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/606473002/20001
6 years, 2 months ago (2014-09-25 00:00:35 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 90811acb10285642eed1699207bdb5d24c987922
6 years, 2 months ago (2014-09-25 01:35:38 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 01:36:21 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d7743bab4d428ef413320f9e71ed08b62255573b
Cr-Commit-Position: refs/heads/master@{#296613}

Powered by Google App Engine
This is Rietveld 408576698